[jira] [Commented] (HDFS-13402) RBF: Fix java doc for StateStoreFileSystemImpl

2018-04-08 Thread Yiran Wu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429738#comment-16429738 ] Yiran Wu commented on HDFS-13402: - Thanks [~linyiqun] merged this code and thanks [~elgoiri], [~ajayydv]

[jira] [Commented] (HDFS-13402) RBF: Fix java doc for StateStoreFileSystemImpl

2018-04-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429617#comment-16429617 ] Hudson commented on HDFS-13402: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13941 (See

[jira] [Commented] (HDFS-13402) RBF: Fix java doc for StateStoreFileSystemImpl

2018-04-07 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429611#comment-16429611 ] Yiqun Lin commented on HDFS-13402: -- LGTM, +1. I'd like to commit this now. > RBF: Fix java doc for

[jira] [Commented] (HDFS-13402) RBF: Fix java doc for StateStoreFileSystemImpl

2018-04-07 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429553#comment-16429553 ] Íñigo Goiri commented on HDFS-13402: Thanks [~yiran] for [^HDFS-13402.003.patch]. +1 > RBF: Fix

[jira] [Commented] (HDFS-13402) RBF: Fix java doc for StateStoreFileSystemImpl

2018-04-07 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429455#comment-16429455 ] genericqa commented on HDFS-13402: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13402) RBF: Fix java doc for StateStoreFileSystemImpl

2018-04-07 Thread Yiran Wu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429400#comment-16429400 ] Yiran Wu commented on HDFS-13402: - Thank you very much [~elgoiri] and [~ajayydv]. The new DOC is clearer.

[jira] [Commented] (HDFS-13402) RBF: Fix java doc for StateStoreFileSystemImpl

2018-04-06 Thread Ajay Kumar (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428851#comment-16428851 ] Ajay Kumar commented on HDFS-13402: --- [~elgoiri] +1 for new javadoc you suggested. minor tweak {code}The

[jira] [Commented] (HDFS-13402) RBF: Fix java doc for StateStoreFileSystemImpl

2018-04-06 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428501#comment-16428501 ] Íñigo Goiri commented on HDFS-13402: Thanks [~yiran], in [^HDFS-13402.002.patch] the line is still

[jira] [Commented] (HDFS-13402) RBF: Fix java doc for StateStoreFileSystemImpl

2018-04-06 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428088#comment-16428088 ] genericqa commented on HDFS-13402: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13402) RBF: Fix java doc for StateStoreFileSystemImpl

2018-04-06 Thread Yiran Wu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428046#comment-16428046 ] Yiran Wu commented on HDFS-13402: - Thanks [~elgoiri] and [~ajayydv] for reviewing my code, I added a new

[jira] [Commented] (HDFS-13402) RBF: Fix java doc for StateStoreFileSystemImpl

2018-04-05 Thread Ajay Kumar (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427421#comment-16427421 ] Ajay Kumar commented on HDFS-13402: --- space missing at L44 C27. Wondering if we can improve second line

[jira] [Commented] (HDFS-13402) RBF: Fix java doc for StateStoreFileSystemImpl

2018-04-05 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427189#comment-16427189 ] Íñigo Goiri commented on HDFS-13402: Thanks [~yiran] for reporting. Do you mind fixing the checkstyle

[jira] [Commented] (HDFS-13402) RBF: Fix java doc for StateStoreFileSystemImpl

2018-04-05 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426906#comment-16426906 ] genericqa commented on HDFS-13402: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||