[
https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429738#comment-16429738
]
Yiran Wu commented on HDFS-13402:
-
Thanks [~linyiqun] merged this code and thanks [~elgoiri], [~ajayydv]
[
https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429617#comment-16429617
]
Hudson commented on HDFS-13402:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13941 (See
[
https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429611#comment-16429611
]
Yiqun Lin commented on HDFS-13402:
--
LGTM, +1. I'd like to commit this now.
> RBF: Fix java doc for
[
https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429553#comment-16429553
]
Íñigo Goiri commented on HDFS-13402:
Thanks [~yiran] for [^HDFS-13402.003.patch].
+1
> RBF: Fix
[
https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429455#comment-16429455
]
genericqa commented on HDFS-13402:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429400#comment-16429400
]
Yiran Wu commented on HDFS-13402:
-
Thank you very much [~elgoiri] and [~ajayydv]. The new DOC is clearer.
[
https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428851#comment-16428851
]
Ajay Kumar commented on HDFS-13402:
---
[~elgoiri] +1 for new javadoc you suggested. minor tweak
{code}The
[
https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428501#comment-16428501
]
Íñigo Goiri commented on HDFS-13402:
Thanks [~yiran], in [^HDFS-13402.002.patch] the line is still
[
https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428088#comment-16428088
]
genericqa commented on HDFS-13402:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428046#comment-16428046
]
Yiran Wu commented on HDFS-13402:
-
Thanks [~elgoiri] and [~ajayydv] for reviewing my code, I added a new
[
https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427421#comment-16427421
]
Ajay Kumar commented on HDFS-13402:
---
space missing at L44 C27. Wondering if we can improve second line
[
https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427189#comment-16427189
]
Íñigo Goiri commented on HDFS-13402:
Thanks [~yiran] for reporting.
Do you mind fixing the checkstyle
[
https://issues.apache.org/jira/browse/HDFS-13402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426906#comment-16426906
]
genericqa commented on HDFS-13402:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
13 matches
Mail list logo