[jira] [Commented] (HDFS-13540) DFSStripedInputStream should not allocate new buffers during close / unbuffer

2018-05-20 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482175#comment-16482175 ] Xiao Chen commented on HDFS-13540: -- Thanks for the review Sammi. [^HDFS-13540.04.patch] to address both

[jira] [Commented] (HDFS-13540) DFSStripedInputStream should not allocate new buffers during close / unbuffer

2018-05-17 Thread SammiChen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478871#comment-16478871 ] SammiChen commented on HDFS-13540: -- [~xiaochen], thanks for the explanation. It makes sense to change the

[jira] [Commented] (HDFS-13540) DFSStripedInputStream should not allocate new buffers during close / unbuffer

2018-05-15 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476822#comment-16476822 ] Xiao Chen commented on HDFS-13540: -- Thanks for the review Sammi. Good question! {{readWithStrategy}} may

[jira] [Commented] (HDFS-13540) DFSStripedInputStream should not allocate new buffers during close / unbuffer

2018-05-15 Thread SammiChen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476804#comment-16476804 ] SammiChen commented on HDFS-13540: -- Hi [~xiaochen], thanks for working on this!

[jira] [Commented] (HDFS-13540) DFSStripedInputStream should not allocate new buffers during close / unbuffer

2018-05-15 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476687#comment-16476687 ] genericqa commented on HDFS-13540: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13540) DFSStripedInputStream should not allocate new buffers during close / unbuffer

2018-05-15 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476527#comment-16476527 ] Xiao Chen commented on HDFS-13540: -- Rebased to latest trunk and fixed checkstyle > DFSStripedInputStream

[jira] [Commented] (HDFS-13540) DFSStripedInputStream should not allocate new buffers during close / unbuffer

2018-05-13 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473777#comment-16473777 ] Xiao Chen commented on HDFS-13540: -- Hi [~ajisakaa] / [~Sammi], do you have cycles to review this? Thanks

[jira] [Commented] (HDFS-13540) DFSStripedInputStream should not allocate new buffers during close / unbuffer

2018-05-09 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469584#comment-16469584 ] genericqa commented on HDFS-13540: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13540) DFSStripedInputStream should not allocate new buffers during close / unbuffer

2018-05-09 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468511#comment-16468511 ] genericqa commented on HDFS-13540: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13540) DFSStripedInputStream should not allocate new buffers during close / unbuffer

2018-05-08 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468291#comment-16468291 ] Xiao Chen commented on HDFS-13540: -- added a test and next run should include hadoop-hdfs too >

[jira] [Commented] (HDFS-13540) DFSStripedInputStream should not allocate new buffers during close / unbuffer

2018-05-08 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468183#comment-16468183 ] genericqa commented on HDFS-13540: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||