[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-09-03 Thread Chen Liang (Jira)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921781#comment-16921781 ] Chen Liang commented on HDFS-13541: --- Thanks [~shv]! I've pushed v003 patch of branch-2,

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-08-28 Thread Konstantin Shvachko (Jira)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16918169#comment-16918169 ] Konstantin Shvachko commented on HDFS-13541: {{PBHelperClient}} still has a t

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-08-28 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16917492#comment-16917492 ] Hadoop QA commented on HDFS-13541: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-08-27 Thread Chen Liang (Jira)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16917072#comment-16917072 ] Chen Liang commented on HDFS-13541: --- Thanks for the review [~shv] ! Post v003 patch. >

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-08-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916298#comment-16916298 ] Hadoop QA commented on HDFS-13541: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-08-26 Thread Konstantin Shvachko (Jira)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916256#comment-16916256 ] Konstantin Shvachko commented on HDFS-13541: Comments for branch-2 v02 patch:

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-08-26 Thread Chen Liang (Jira)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916193#comment-16916193 ] Chen Liang commented on HDFS-13541: --- The branch-2 v001 patch has a bad backport causing

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-08-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916119#comment-16916119 ] Hadoop QA commented on HDFS-13541: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-08-23 Thread Chen Liang (Jira)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914529#comment-16914529 ] Chen Liang commented on HDFS-13541: --- Thanks [~shv]! I've committed to branch-3.1. > Na

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-08-22 Thread Konstantin Shvachko (Jira)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913816#comment-16913816 ] Konstantin Shvachko commented on HDFS-13541: +1 on v02 patch for branch 3.1.

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-08-21 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912922#comment-16912922 ] Hadoop QA commented on HDFS-13541: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-08-21 Thread Chen Liang (Jira)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912666#comment-16912666 ] Chen Liang commented on HDFS-13541: --- Thanks [~shv] for the review. Post v002 patch to a

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-08-20 Thread Konstantin Shvachko (Jira)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911832#comment-16911832 ] Konstantin Shvachko commented on HDFS-13541: Couple things for 3.1 patch: # I

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-08-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16909560#comment-16909560 ] Hadoop QA commented on HDFS-13541: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-08-16 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16909310#comment-16909310 ] Chen Liang commented on HDFS-13541: --- Thanks for the review [~shv]! I've committed to br

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-08-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907810#comment-16907810 ] Hadoop QA commented on HDFS-13541: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-08-14 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907745#comment-16907745 ] Konstantin Shvachko commented on HDFS-13541: +1. Compared most of the files w

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-08-14 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907696#comment-16907696 ] Chen Liang commented on HDFS-13541: --- Thanks for the review [~shv], post v002 patch. {{T

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-08-14 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907609#comment-16907609 ] Konstantin Shvachko commented on HDFS-13541: Looks good overall. # I suggest

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-07-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897696#comment-16897696 ] Hadoop QA commented on HDFS-13541: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2019-07-31 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897581#comment-16897581 ] Chen Liang commented on HDFS-13541: --- Working on backport to branch-3.x and branch-2, po

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2018-05-25 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491307#comment-16491307 ] Konstantin Shvachko commented on HDFS-13541: {quote}I prefer the approach wher

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2018-05-25 Thread Benoy Antony (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491147#comment-16491147 ] Benoy Antony commented on HDFS-13541: - {quote} in our environment, cross data center

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2018-05-10 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471159#comment-16471159 ] Chen Liang commented on HDFS-13541: --- Thought a bit more about passing additional fields

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2018-05-10 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470781#comment-16470781 ] Chen Liang commented on HDFS-13541: --- Thanks a lot for taking a look [~benoyantony]! bq.

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2018-05-10 Thread Benoy Antony (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470684#comment-16470684 ] Benoy Antony commented on HDFS-13541: - Thanks [~vagarychen]. I have reviewed the docum

[jira] [Commented] (HDFS-13541) NameNode Port based selective encryption

2018-05-09 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469155#comment-16469155 ] Chen Liang commented on HDFS-13541: --- [~benoyantony], would you be interested in taking a