[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987855#comment-16987855
]
Jinglun commented on HDFS-13811:
Thanks [~linyiqun] for the nice review !
> RBF: Race condition between
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987723#comment-16987723
]
Hudson commented on HDFS-13811:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17720 (See
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987687#comment-16987687
]
Yiqun Lin commented on HDFS-13811:
--
LGTM, +1. Commit this shortly.
> RBF: Race condition between router
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987636#comment-16987636
]
Hadoop QA commented on HDFS-13811:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987586#comment-16987586
]
Jinglun commented on HDFS-13811:
Hi [~linyiqun], thanks your comments ! I rollback the changes except the
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987503#comment-16987503
]
Yiqun Lin commented on HDFS-13811:
--
[~LiJinglun], following change of the unit test can also rollback.
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986920#comment-16986920
]
Hadoop QA commented on HDFS-13811:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986867#comment-16986867
]
Jinglun commented on HDFS-13811:
Hi [~linyiqun], thanks your nice comments ! Fix the failed unit tests
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986773#comment-16986773
]
Yiqun Lin commented on HDFS-13811:
--
Thanks for updating the patch, [~LiJinglun]. The change almost looks
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986164#comment-16986164
]
Hadoop QA commented on HDFS-13811:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986106#comment-16986106
]
Jinglun commented on HDFS-13811:
Upload v05 fix check style. The failed unit tests are caused by
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985952#comment-16985952
]
Hadoop QA commented on HDFS-13811:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985921#comment-16985921
]
Jinglun commented on HDFS-13811:
Hi [~linyiqun], thanks your clear explanation ! Upload v04 using the
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985378#comment-16985378
]
Yiqun Lin commented on HDFS-13811:
--
{quote}
I haven't looked into the code, just a guess: is the web UI
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984780#comment-16984780
]
Jinglun commented on HDFS-13811:
Hi [~linyiqun], thanks your comments ! I didn't think about the web UI
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984758#comment-16984758
]
Yiqun Lin commented on HDFS-13811:
--
Hi [~LiJinglun], I take a look for the major change of the patch. I
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984238#comment-16984238
]
Yiqun Lin commented on HDFS-13811:
--
[~LiJinglun], sorry for the delayed review. I was busy on reviewing
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981402#comment-16981402
]
Jinglun commented on HDFS-13811:
Hi [~linyiqun], just a minor reminder of this jira. Do you have time to
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976400#comment-16976400
]
Yiqun Lin commented on HDFS-13811:
--
I will take some time to revisit this Jira recent days.
> RBF: Race
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976121#comment-16976121
]
Ayush Saxena commented on HDFS-13811:
-
[~linyiqun] you have been following this from start, The idea
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972201#comment-16972201
]
Hadoop QA commented on HDFS-13811:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972153#comment-16972153
]
Jinglun commented on HDFS-13811:
Upload v03 fixing findbugs error. Hi [~ayushtkn] would you help to
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972096#comment-16972096
]
Hadoop QA commented on HDFS-13811:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972065#comment-16972065
]
Jinglun commented on HDFS-13811:
Rebase and upload v02.
> RBF: Race condition between router admin quota
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972025#comment-16972025
]
Hadoop QA commented on HDFS-13811:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972023#comment-16972023
]
Jinglun commented on HDFS-13811:
Now we have quota & quota usage saved in 3 places: state store, mount
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969147#comment-16969147
]
Hadoop QA commented on HDFS-13811:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969148#comment-16969148
]
Ayush Saxena commented on HDFS-13811:
-
Seems safe to take over l. Go ahead, Jinglun
> RBF: Race
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969145#comment-16969145
]
Jinglun commented on HDFS-13811:
{quote}IMO we should not update the mount table statestore internally,
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872046#comment-16872046
]
Hadoop QA commented on HDFS-13811:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742375#comment-16742375
]
Íñigo Goiri commented on HDFS-13811:
[~dibyendu_hadoop] can you tackle [~linyiqun]'s comments?
>
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704423#comment-16704423
]
Yiqun Lin commented on HDFS-13811:
--
Hi [~dibyendu_hadoop],
{quote}
I haven't change the existing logic
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702765#comment-16702765
]
Dibyendu Karmakar commented on HDFS-13811:
--
Thanks [~linyiqun] for the review.
in
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696359#comment-16696359
]
Yiqun Lin commented on HDFS-13811:
--
Thanks for the explanation, [~dibyendu_hadoop]. I think I have got
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695776#comment-16695776
]
Hadoop QA commented on HDFS-13811:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695590#comment-16695590
]
Dibyendu Karmakar commented on HDFS-13811:
--
Thanks [~linyiqun] for the review.
Here I am taking
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694887#comment-16694887
]
Yiqun Lin commented on HDFS-13811:
--
Take a quick look for the patch, looks like we change a lot.
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694874#comment-16694874
]
Hadoop QA commented on HDFS-13811:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694798#comment-16694798
]
Yiqun Lin commented on HDFS-13811:
--
Hi [~dibyendu_hadoop], since HDFS-13553 was closed. I convert this
39 matches
Mail list logo
