[
https://issues.apache.org/jira/browse/HDFS-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604073#comment-16604073
]
yanghuafeng commented on HDFS-13836:
Thanks for your tests. If there are other proble
[
https://issues.apache.org/jira/browse/HDFS-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593980#comment-16593980
]
Íñigo Goiri commented on HDFS-13836:
The unit tests for both run with no issues:
http
[
https://issues.apache.org/jira/browse/HDFS-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593192#comment-16593192
]
genericqa commented on HDFS-13836:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HDFS-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593157#comment-16593157
]
yanghuafeng commented on HDFS-13836:
* Add null check in the ZkCuratorManager#getStri
[
https://issues.apache.org/jira/browse/HDFS-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592959#comment-16592959
]
Íñigo Goiri commented on HDFS-13836:
I would try to move to the ZkCuratorManager and
[
https://issues.apache.org/jira/browse/HDFS-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592616#comment-16592616
]
yanghuafeng commented on HDFS-13836:
I have found that it may be better to manage nul
[
https://issues.apache.org/jira/browse/HDFS-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591888#comment-16591888
]
Íñigo Goiri commented on HDFS-13836:
Sorry for not catching this earlier, I think we
[
https://issues.apache.org/jira/browse/HDFS-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591144#comment-16591144
]
genericqa commented on HDFS-13836:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HDFS-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591092#comment-16591092
]
yanghuafeng commented on HDFS-13836:
>From my side, it is essential to keep the logs.
[
https://issues.apache.org/jira/browse/HDFS-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590482#comment-16590482
]
Íñigo Goiri commented on HDFS-13836:
[^HDFS-13836.003.patch] LGTM.
I'm not sure if w
[
https://issues.apache.org/jira/browse/HDFS-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589683#comment-16589683
]
genericqa commented on HDFS-13836:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HDFS-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589640#comment-16589640
]
yanghuafeng commented on HDFS-13836:
In my opinion, the above code would be more simp
[
https://issues.apache.org/jira/browse/HDFS-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588845#comment-16588845
]
Íñigo Goiri commented on HDFS-13836:
Thanks [~hfyang20071] for [^HDFS-13836.002.patc
[
https://issues.apache.org/jira/browse/HDFS-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588486#comment-16588486
]
genericqa commented on HDFS-13836:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HDFS-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588475#comment-16588475
]
yanghuafeng commented on HDFS-13836:
Add a unit test case, please review the code. [~
[
https://issues.apache.org/jira/browse/HDFS-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586403#comment-16586403
]
genericqa commented on HDFS-13836:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586342#comment-16586342
]
Íñigo Goiri commented on HDFS-13836:
Thanks [~hfyang20071], could you add a unit test
17 matches
Mail list logo