[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871576#comment-16871576
]
Hudson commented on HDFS-13869:
---
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16813 (See
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722680#comment-16722680
]
Ranith Sardar commented on HDFS-13869:
--
Thanks [~linyiqun] for committing . :)
Thanks [~elgoiri]
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722672#comment-16722672
]
Yiqun Lin commented on HDFS-13869:
--
Committed to HDFS-13891 branch.
Thanks [~RANith] for the
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722657#comment-16722657
]
Yiqun Lin commented on HDFS-13869:
--
LGTM, +1. Commit this shortly.
> RBF: Handle NPE for
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721702#comment-16721702
]
Íñigo Goiri commented on HDFS-13869:
+1 on [^HDFS-13869-HDFS-13891.011.patch].
> RBF: Handle NPE for
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721232#comment-16721232
]
Hadoop QA commented on HDFS-13869:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719316#comment-16719316
]
Íñigo Goiri commented on HDFS-13869:
Other than the unused import this looks good.
> RBF: Handle NPE
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718611#comment-16718611
]
Hadoop QA commented on HDFS-13869:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718520#comment-16718520
]
Ranith Sardar commented on HDFS-13869:
--
Hi [~elgoiri], thanks for reviewing the patch.
In my
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709019#comment-16709019
]
Íñigo Goiri commented on HDFS-13869:
A couple comments on [^HDFS-13869-HDFS-13891.009.patch]:
*
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708763#comment-16708763
]
Yiqun Lin commented on HDFS-13869:
--
I have reverted the latest commit that causes the compile error.
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708746#comment-16708746
]
Hadoop QA commented on HDFS-13869:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708620#comment-16708620
]
Hadoop QA commented on HDFS-13869:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708563#comment-16708563
]
Ranith Sardar commented on HDFS-13869:
--
Updated the patch for HDFS-13891 branch. Please check it
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669013#comment-16669013
]
Íñigo Goiri commented on HDFS-13869:
[~RANith] can you provide a patch based on HDFS-13891?
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621807#comment-16621807
]
Ranith Sardar commented on HDFS-13869:
--
Yes [~elgoiri], can move this to HDFS-13891.
> RBF: Handle
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615560#comment-16615560
]
Surendra Singh Lilhore commented on HDFS-13869:
---
+1 LGTM
> RBF: Handle NPE for
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615266#comment-16615266
]
Íñigo Goiri commented on HDFS-13869:
Thanks [~RANith] for [^HDFS-13869-007.patch].
I would avoid the
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614694#comment-16614694
]
Hadoop QA commented on HDFS-13869:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614527#comment-16614527
]
Hadoop QA commented on HDFS-13869:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612487#comment-16612487
]
Íñigo Goiri commented on HDFS-13869:
Thanks [~RANith] for [^HDFS-13869-005.patch].
Is there a way we
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612004#comment-16612004
]
Hadoop QA commented on HDFS-13869:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611836#comment-16611836
]
Ranith Sardar commented on HDFS-13869:
--
Hi [~elgoiri], updated the patch with correct return message
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608629#comment-16608629
]
Ranith Sardar commented on HDFS-13869:
--
We will get this exception when the metrics are not
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607316#comment-16607316
]
Íñigo Goiri commented on HDFS-13869:
{{TestDisableRouterQuota}} looks like a weird place to test
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606998#comment-16606998
]
Hadoop QA commented on HDFS-13869:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606865#comment-16606865
]
Ranith Sardar commented on HDFS-13869:
--
[~elgoiri], thank you for your suggestion. Uploaded new
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603265#comment-16603265
]
Íñigo Goiri commented on HDFS-13869:
I like the approach in [^HDFS-13869-003.diff] better.
I'm not
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601922#comment-16601922
]
Hadoop QA commented on HDFS-13869:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601773#comment-16601773
]
Hadoop QA commented on HDFS-13869:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601732#comment-16601732
]
Ranith Sardar commented on HDFS-13869:
--
Thankx [~surendrasingh] for reporting this issue.
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596555#comment-16596555
]
Íñigo Goiri commented on HDFS-13869:
>From the trace, it looks like the null part is
[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595860#comment-16595860
]
Ranith Sardar commented on HDFS-13869:
--
Uploaded the patch. Please review it once.
> RBF: Handle
33 matches
Mail list logo