[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-03 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733581#comment-16733581 ] Íñigo Goiri commented on HDFS-14181: [^HDFS-14181.08.patch] looks pretty much it. Can you avoid the

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733184#comment-16733184 ] Hadoop QA commented on HDFS-14181: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-03 Thread Sihai Ke (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733134#comment-16733134 ] Sihai Ke commented on HDFS-14181: - Sorry for there is a white space line, I upload a new patch

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733011#comment-16733011 ] Hadoop QA commented on HDFS-14181: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-03 Thread Sihai Ke (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732940#comment-16732940 ] Sihai Ke commented on HDFS-14181: - [~ayushtkn] I upload a patch HDFS-14181.07.patch which is same as

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-02 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732734#comment-16732734 ] Ayush Saxena commented on HDFS-14181: - Thanks [~sihai] for the patch!!! I guess the build failed in

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-02 Thread Sihai Ke (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732672#comment-16732672 ] Sihai Ke commented on HDFS-14181: - [~elgoiri] [~hexiaoqiao]  [~ayushtkn]  thanks for comments, I upload a

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-02 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732304#comment-16732304 ] Chen Liang commented on HDFS-14181: --- Sorry for the late response, just got back from vacation. The fix

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-02 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732232#comment-16732232 ] Íñigo Goiri commented on HDFS-14181: * The reentrant lock should be fine; both places have finally so

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-02 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732230#comment-16732230 ] Ayush Saxena commented on HDFS-14181: - Thanks [~sihai] for the great work here. As [~hexiaoqiao]

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-02 Thread He Xiaoqiao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731828#comment-16731828 ] He Xiaoqiao commented on HDFS-14181: [~sihai], Thanks for your work, as you mentioned before, read

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731810#comment-16731810 ] Hadoop QA commented on HDFS-14181: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-01 Thread Sihai Ke (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731784#comment-16731784 ] Sihai Ke commented on HDFS-14181: - [~hexiaoqiao]  [~elgoiri] [~ayushtkn] I add another patch

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-01 Thread Sihai Ke (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731763#comment-16731763 ] Sihai Ke commented on HDFS-14181: - [~hexiaoqiao]  [~elgoiri] [~ayushtkn] thanks for comments, I think the

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-01 Thread He Xiaoqiao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731749#comment-16731749 ] He Xiaoqiao commented on HDFS-14181: [~elgoiri][~sihai] Thanks for your corrected comments.

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-01 Thread Sihai Ke (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731737#comment-16731737 ] Sihai Ke commented on HDFS-14181: - [~elgoiri] I have uploaded a patch HDFS-14181.03.patch which contain

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-01 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731667#comment-16731667 ] Íñigo Goiri commented on HDFS-14181: Thanks [~sihai] can you post the patch with both the fix and the

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731595#comment-16731595 ] Hadoop QA commented on HDFS-14181: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-01 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731583#comment-16731583 ] Ayush Saxena commented on HDFS-14181: - Thanx [~sihai] for the patch. I too agree with [~elgoiri]

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731580#comment-16731580 ] Hadoop QA commented on HDFS-14181: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-01 Thread Sihai Ke (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731573#comment-16731573 ] Sihai Ke commented on HDFS-14181: - [~ayushtkn] Sorry for the incorrect patch name format, I upload two

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-01 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731570#comment-16731570 ] Ayush Saxena commented on HDFS-14181: - [~sihai] The build got triggered check

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2019-01-01 Thread Sihai Ke (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731563#comment-16731563 ] Sihai Ke commented on HDFS-14181: - [~elgoiri] I updated the patch because code stype (code length is

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2018-12-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731538#comment-16731538 ] Hadoop QA commented on HDFS-14181: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2018-12-31 Thread Sihai Ke (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731528#comment-16731528 ] Sihai Ke commented on HDFS-14181: - [~elgoiri] I have added another patch

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2018-12-31 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731433#comment-16731433 ] Íñigo Goiri commented on HDFS-14181: I see value on having a proper use of this method instead of

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2018-12-30 Thread Sihai Ke (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731011#comment-16731011 ] Sihai Ke commented on HDFS-14181: - hi [~hexiaoqiao], thanks for your comments, I think why this bug is

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2018-12-30 Thread He Xiaoqiao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730958#comment-16730958 ] He Xiaoqiao commented on HDFS-14181: [~sihai] Thanks for your reporting, I think it may be not bug,

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2018-12-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730889#comment-16730889 ] Hadoop QA commented on HDFS-14181: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2018-12-29 Thread Sihai Ke (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730875#comment-16730875 ] Sihai Ke commented on HDFS-14181: - [~elgoiri]  I have uploaded the patch, and the network topoloty

[jira] [Commented] (HDFS-14181) Suspect there is a bug in NetworkTopology.java chooseRandom function.

2018-12-29 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730774#comment-16730774 ] Íñigo Goiri commented on HDFS-14181: Thanks [~sihai] for reporting. Can you upload a patch with the