[jira] [Commented] (HDFS-14250) [Standby Reads] msync should sync with active NameNode to fetch the latest stateID

2019-02-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758761#comment-16758761 ] Hadoop QA commented on HDFS-14250: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14250) [Standby Reads] msync should sync with active NameNode to fetch the latest stateID

2019-02-01 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758715#comment-16758715 ] Erik Krogen commented on HDFS-14250: Great ! +1 from me pending Jenkins, will commit

[jira] [Commented] (HDFS-14250) [Standby Reads] msync should sync with active NameNode to fetch the latest stateID

2019-02-01 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758707#comment-16758707 ] Chao Sun commented on HDFS-14250: - Thanks [~xkrogen]! Attached patch v1 to address the co

[jira] [Commented] (HDFS-14250) [Standby Reads] msync should sync with active NameNode to fetch the latest stateID

2019-02-01 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758643#comment-16758643 ] Erik Krogen commented on HDFS-14250: v000 patch LGTM, only minor nit is that I would

[jira] [Commented] (HDFS-14250) [Standby Reads] msync should sync with active NameNode to fetch the latest stateID

2019-01-31 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757742#comment-16757742 ] Chao Sun commented on HDFS-14250: - Yes, I think we can just use {{activeOnly}} for this t

[jira] [Commented] (HDFS-14250) [Standby Reads] msync should sync with active NameNode to fetch the latest stateID

2019-01-31 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757722#comment-16757722 ] Erik Krogen commented on HDFS-14250: I don't think we want to make it write anything

[jira] [Commented] (HDFS-14250) [Standby Reads] msync should sync with active NameNode to fetch the latest stateID

2019-01-31 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757712#comment-16757712 ] Chao Sun commented on HDFS-14250: - [~xkrogen] you are right. Maybe {{msync}} can simply b

[jira] [Commented] (HDFS-14250) [Standby Reads] msync should sync with active NameNode to fetch the latest stateID

2019-01-31 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757704#comment-16757704 ] Erik Krogen commented on HDFS-14250: I think #2 is not necessary -- this will be hand