[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969498#comment-16969498
]
Íñigo Goiri commented on HDFS-14284:
There must be something with the protobuf that needs to be
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969200#comment-16969200
]
Ayush Saxena commented on HDFS-14284:
-
Checked in further, Observed while unwrapping only the
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964271#comment-16964271
]
Ayush Saxena commented on HDFS-14284:
-
Thanx [~hemanthboyina] for the patch.
As I said before, please
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963211#comment-16963211
]
hemanthboyina commented on HDFS-14284:
--
updated the patch with comments fixed , please review
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962301#comment-16962301
]
Hadoop QA commented on HDFS-14284:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961893#comment-16961893
]
hemanthboyina commented on HDFS-14284:
--
{quote}Derrive the RouterIOException from the
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960790#comment-16960790
]
Ayush Saxena commented on HDFS-14284:
-
Thanx [~hemanthboyina] for the patch. Couple of comments :
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959178#comment-16959178
]
Hadoop QA commented on HDFS-14284:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956337#comment-16956337
]
hemanthboyina commented on HDFS-14284:
--
thanks for d review [~ayushtkn]
{quote}I don't think that is
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955288#comment-16955288
]
Ayush Saxena commented on HDFS-14284:
-
I checked it doesn't throw NPE, But just prints {{null from
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955287#comment-16955287
]
Ayush Saxena commented on HDFS-14284:
-
I have a doubt :
If RIOE gets created using this :
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955270#comment-16955270
]
Íñigo Goiri commented on HDFS-14284:
+1 on [^HDFS-14284.006.patch].
> RBF: Log Router identifier
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955130#comment-16955130
]
hemanthboyina commented on HDFS-14284:
--
thanks for confirming [~elgoiri] , i think all review
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953043#comment-16953043
]
Íñigo Goiri commented on HDFS-14284:
Thanks [~ayushtkn], yes, that's it, RemoteException only
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952572#comment-16952572
]
Ayush Saxena commented on HDFS-14284:
-
I didn't catch much the discussion but, if you both are
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952559#comment-16952559
]
hemanthboyina commented on HDFS-14284:
--
i dont think it is becuase of RouterIOException
i have even
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952289#comment-16952289
]
Íñigo Goiri commented on HDFS-14284:
Interesting, there are some exceptions that get unwrapped.
I'm
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952173#comment-16952173
]
hemanthboyina commented on HDFS-14284:
--
even if we use FileSystem Interface we get the exception as
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951226#comment-16951226
]
Íñigo Goiri commented on HDFS-14284:
I may be wrong, but I think that if we use the FileSystem
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950241#comment-16950241
]
Hadoop QA commented on HDFS-14284:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946937#comment-16946937
]
Ayush Saxena commented on HDFS-14284:
-
[~brahmareddy] comment for {{NoNamenodesAvailableException}}
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946617#comment-16946617
]
Hadoop QA commented on HDFS-14284:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946108#comment-16946108
]
Íñigo Goiri commented on HDFS-14284:
For the getMessage(), let's just do:
{code}
@Override
public
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945586#comment-16945586
]
hemanthboyina commented on HDFS-14284:
--
test case failures seems unrelated , pls review the patch
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945065#comment-16945065
]
Hadoop QA commented on HDFS-14284:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945046#comment-16945046
]
hemanthboyina commented on HDFS-14284:
--
updated patch with check style issues fixed and test
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945043#comment-16945043
]
Hadoop QA commented on HDFS-14284:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943111#comment-16943111
]
Brahma Reddy Battula commented on HDFS-14284:
-
Ok.Just I want to confirm when router is can't
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942989#comment-16942989
]
Íñigo Goiri commented on HDFS-14284:
In this particular case, we had issues with our secure ZK
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942477#comment-16942477
]
Brahma Reddy Battula commented on HDFS-14284:
-
{quote}We will try to cover as many cases as
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942437#comment-16942437
]
Ayush Saxena commented on HDFS-14284:
-
[~brahmareddy] I agree we should shut down the router,
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942391#comment-16942391
]
Íñigo Goiri commented on HDFS-14284:
Correct, that's one case.
We will try to cover as many cases as
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942360#comment-16942360
]
Brahma Reddy Battula commented on HDFS-14284:
-
{quote}Router that had issues (no access to
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942313#comment-16942313
]
Íñigo Goiri commented on HDFS-14284:
[~brahmareddy], the main reason for me to open this JIRA was
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942294#comment-16942294
]
Brahma Reddy Battula commented on HDFS-14284:
-
Agree with [~crh]. May be we can handle
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938979#comment-16938979
]
CR Hota commented on HDFS-14284:
[~hemanthboyina] [~inigoiri] [~ayushtkn] Thanks for the discussion so
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938155#comment-16938155
]
Iñigo Goiri commented on HDFS-14284:
As I mentioned before, I think routerId should be a field in
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938093#comment-16938093
]
Hadoop QA commented on HDFS-14284:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937848#comment-16937848
]
Ayush Saxena commented on HDFS-14284:
-
IMO changing to RIOE from IOE won’t be a problem. Anyone
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937813#comment-16937813
]
hemanthboyina commented on HDFS-14284:
--
have some questions [~elgoiri]
{code:java}
throw new
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937157#comment-16937157
]
Ayush Saxena commented on HDFS-14284:
-
Thanx [~elgoiri] makes sense. we can extend the same RIOE for
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937146#comment-16937146
]
Íñigo Goiri commented on HDFS-14284:
{quote}
do we have any advantage of having a RouterIOException,
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937111#comment-16937111
]
Ayush Saxena commented on HDFS-14284:
-
Thanx [~hemanthboyina] for the patch.
I think the trace with
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937105#comment-16937105
]
hemanthboyina commented on HDFS-14284:
--
_is there any static method we can get?_
there
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937085#comment-16937085
]
Íñigo Goiri commented on HDFS-14284:
Let's make routerId a field and add a method {{getRouterId()}}
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937025#comment-16937025
]
hemanthboyina commented on HDFS-14284:
--
attached patch , please review [~elgoiri]
> RBF: Log Router
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936177#comment-16936177
]
Hadoop QA commented on HDFS-14284:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936081#comment-16936081
]
Íñigo Goiri commented on HDFS-14284:
[~hemanthboyina], it would be something like that but that one
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936055#comment-16936055
]
hemanthboyina commented on HDFS-14284:
--
[~elgoiri] appending router id to the message will solve the
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888225#comment-16888225
]
Íñigo Goiri commented on HDFS-14284:
OK, we can add it to the process exception.
I wonder if we
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888071#comment-16888071
]
Ayush Saxena commented on HDFS-14284:
-
I guess we are processing all exception using
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880692#comment-16880692
]
Íñigo Goiri commented on HDFS-14284:
Anything that can tell me from the client who was the Router
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880596#comment-16880596
]
Ayush Saxena commented on HDFS-14284:
-
IIUC Don't we unwrap every exception in Router Before throwing
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876389#comment-16876389
]
Íñigo Goiri commented on HDFS-14284:
Sure, let's see how HDFS-13270 goes.
> RBF: Log Router
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875483#comment-16875483
]
hemanthboyina commented on HDFS-14284:
--
[~elgoiri] if we implement HDFS-13270 (Router Audit Logger )
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771453#comment-16771453
]
Chao Sun commented on HDFS-14284:
-
Agree this could be useful. Perhaps we can make this optional by
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769806#comment-16769806
]
Íñigo Goiri commented on HDFS-14284:
We are getting the remote exception as this:
{code}
Exception in
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769816#comment-16769816
]
Erik Krogen commented on HDFS-14284:
Makes sense to me. IIRC that information may not be available
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769714#comment-16769714
]
Erik Krogen commented on HDFS-14284:
Interesting problem. Can you maybe post a sample stack trace
[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769697#comment-16769697
]
Íñigo Goiri commented on HDFS-14284:
One of the Routers is triggering some exceptions and it is very
60 matches
Mail list logo
