[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823484#comment-16823484 ] Hudson commented on HDFS-14435: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-22 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823438#comment-16823438 ] Erik Krogen commented on HDFS-14435: Thanks all! Committed to trunk. > ObserverReadP

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-22 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823432#comment-16823432 ] Íñigo Goiri commented on HDFS-14435: +1 on [^HDFS-14435.004.patch]. > ObserverReadP

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-22 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823381#comment-16823381 ] Chao Sun commented on HDFS-14435: - +1 from me as well! > ObserverReadProxyProvider is un

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-22 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823376#comment-16823376 ] Chen Liang commented on HDFS-14435: --- [~xkrogen] sorry for the late response... +1 from

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-22 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823373#comment-16823373 ] Erik Krogen commented on HDFS-14435: Hey [~csun], [~elgoiri] -- can I get a binding +

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822132#comment-16822132 ] Hadoop QA commented on HDFS-14435: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-19 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822000#comment-16822000 ] Erik Krogen commented on HDFS-14435: Attached v005 addressing checkstyle issues. > O

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821501#comment-16821501 ] Hadoop QA commented on HDFS-14435: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821465#comment-16821465 ] Hadoop QA commented on HDFS-14435: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821456#comment-16821456 ] Hadoop QA commented on HDFS-14435: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-18 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821396#comment-16821396 ] Erik Krogen commented on HDFS-14435: Argh... Thanks [~csun]. I swear I removed it, no

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-18 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821387#comment-16821387 ] Chao Sun commented on HDFS-14435: - Thanks [~xkrogen]! LGTM to me as well except the white

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-18 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821384#comment-16821384 ] Íñigo Goiri commented on HDFS-14435: [^HDFS-14435.003.patch] LGTM. Let's see if anybo

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-18 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821351#comment-16821351 ] Erik Krogen commented on HDFS-14435: Attached v003 patch rebasing onto trunk and also

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821350#comment-16821350 ] Hadoop QA commented on HDFS-14435: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-18 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821345#comment-16821345 ] Erik Krogen commented on HDFS-14435: Thanks for the reviews [~elgoiri], [~csun]. Upda

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-18 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821280#comment-16821280 ] Chao Sun commented on HDFS-14435: - Looks good [~xkrogen]! Just two nits: 1. there's an e

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820600#comment-16820600 ] Hadoop QA commented on HDFS-14435: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820554#comment-16820554 ] Hadoop QA commented on HDFS-14435: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-17 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820487#comment-16820487 ] Íñigo Goiri commented on HDFS-14435: The code looks a little convoluted. What about s

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-17 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820472#comment-16820472 ] Erik Krogen commented on HDFS-14435: Thanks [~vagarychen]... That was a bad rebase on

[jira] [Commented] (HDFS-14435) ObserverReadProxyProvider is unable to properly fetch HAState from Standby NNs

2019-04-17 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820459#comment-16820459 ] Chen Liang commented on HDFS-14435: --- Thanks for working on this [~xkrogen]! Just a mino