[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901267#comment-16901267 ] Erik Krogen commented on HDFS-14513: I backported this to branch-3.2, and used the branch-2 patch

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899595#comment-16899595 ] He Xiaoqiao commented on HDFS-14513: HDFS-14697 try to backport this issue to other versions. FYI. >

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899564#comment-16899564 ] He Xiaoqiao commented on HDFS-14513: [~xkrogen] Thanks for tracing this issue, totally agree to

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899206#comment-16899206 ] Erik Krogen commented on HDFS-14513: [~elgoiri] [~hexiaoqiao] do you think this is a good candidate

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861369#comment-16861369 ] Hudson commented on HDFS-14513: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16726 (See

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861351#comment-16861351 ] Íñigo Goiri commented on HDFS-14513: I think this is safe enough to commit directly. Committed to

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860696#comment-16860696 ] He Xiaoqiao commented on HDFS-14513: Thanks [~elgoiri], do we need any other guys reviews? > FSImage

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858804#comment-16858804 ] Íñigo Goiri commented on HDFS-14513: [^HDFS-14513.007.patch] LGTM. +1 > FSImage which is saving

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858413#comment-16858413 ] Hadoop QA commented on HDFS-14513: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858383#comment-16858383 ] He Xiaoqiao commented on HDFS-14513: [^HDFS-14513.006.patch] catch IOException in #saveNamespace

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858159#comment-16858159 ] Íñigo Goiri commented on HDFS-14513: {{TestSaveNamespace}} look suspicious, it looks like a cascade

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858096#comment-16858096 ] Hadoop QA commented on HDFS-14513: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857975#comment-16857975 ] He Xiaoqiao commented on HDFS-14513: upload [^HDFS-14513.006.patch] and fix Logger style, Thanks

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857889#comment-16857889 ] Íñigo Goiri commented on HDFS-14513: Let's use the Logger style with {} for the new logs. > FSImage

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857353#comment-16857353 ] Hadoop QA commented on HDFS-14513: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857267#comment-16857267 ] He Xiaoqiao commented on HDFS-14513: upload [^HDFS-14513.005.patch] and remove unit test since

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856854#comment-16856854 ] Íñigo Goiri commented on HDFS-14513: Correct. Let's remove the test as there is nothing we can test.

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856323#comment-16856323 ] He Xiaoqiao commented on HDFS-14513: Thanks [~elgoiri], by seeking junit and shutdownhook, I think

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856163#comment-16856163 ] Íñigo Goiri commented on HDFS-14513: Actually, it doesn't look like there are good ways to test this:

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855748#comment-16855748 ] He Xiaoqiao commented on HDFS-14513: Sorry I am not familiar with mechanism of junit using

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854885#comment-16854885 ] Hadoop QA commented on HDFS-14513: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854875#comment-16854875 ] Íñigo Goiri commented on HDFS-14513: Maybe the fail is happening inside the thread that does the

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854639#comment-16854639 ] He Xiaoqiao commented on HDFS-14513: [~elgoiri], Thanks for your suggestion. [^HDFS-14513.004.patch]

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853192#comment-16853192 ] Íñigo Goiri commented on HDFS-14513: The log I proposed: {code} LOG.error("FSImageSaver cancel

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852826#comment-16852826 ] He Xiaoqiao commented on HDFS-14513: [~elgoiri], Thanks for your reviews. a. it makes sense for me to

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851309#comment-16851309 ] Hadoop QA commented on HDFS-14513: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851289#comment-16851289 ] Íñigo Goiri commented on HDFS-14513: One minor thing, we can let logger output the whole exception:

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851221#comment-16851221 ] Hadoop QA commented on HDFS-14513: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851172#comment-16851172 ] He Xiaoqiao commented on HDFS-14513: [~elgoiri], Thanks for your comments. [^HDFS-14513.003.patch]

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851115#comment-16851115 ] Íñigo Goiri commented on HDFS-14513: Thanks [~hexiaoqiao] for the detailed description, could you

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850816#comment-16850816 ] Hadoop QA commented on HDFS-14513: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850707#comment-16850707 ] He Xiaoqiao commented on HDFS-14513: [~elgoiri] Thanks for taking a look. I would like to offer

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849938#comment-16849938 ] Íñigo Goiri commented on HDFS-14513: Can we use {{org.apache.hadoop.util.ShutdownHookManager}} and

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848432#comment-16848432 ] Hadoop QA commented on HDFS-14513: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14513) FSImage which is saving should be clean while NameNode shutdown

[ https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848392#comment-16848392 ] He Xiaoqiao commented on HDFS-14513: [^HDFS-14513.001.patch] Add hook for FSImageSaver and clean