[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886624#comment-16886624
]
Jinglun commented on HDFS-14547:
Thanks [~xkrogen] for your nice review and comments.:)
>
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885822#comment-16885822
]
Hadoop QA commented on HDFS-14547:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885770#comment-16885770
]
Jinglun commented on HDFS-14547:
My bad:(, I should check the patch more carefully, very sorry for that.
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885339#comment-16885339
]
Erik Krogen commented on HDFS-14547:
Hey [~LiJinglun], you can also remove the {{throws
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884341#comment-16884341
]
Hadoop QA commented on HDFS-14547:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884322#comment-16884322
]
Jinglun commented on HDFS-14547:
Hi [~xkrogen], thanks for your great suggestions. Fixing checkstyle,
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883891#comment-16883891
]
Erik Krogen commented on HDFS-14547:
Besides fixing up the checkstyle and Java 7 compilation issues,
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883571#comment-16883571
]
Hadoop QA commented on HDFS-14547:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883504#comment-16883504
]
Jinglun commented on HDFS-14547:
Hi [~xkrogen], I upload a new patch for branch-2.9, with all lambdas
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880851#comment-16880851
]
Jinglun commented on HDFS-14547:
Hi [~xkrogen], thanks for the commit. I will put a patch for branch-2
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880758#comment-16880758
]
Erik Krogen commented on HDFS-14547:
I was unable to reproduce the failing tests locally. Surprising
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880753#comment-16880753
]
Hudson commented on HDFS-14547:
---
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16870 (See
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875694#comment-16875694
]
Hadoop QA commented on HDFS-14547:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875634#comment-16875634
]
Jinglun commented on HDFS-14547:
Hi [~xkrogen], thanks for your nice suggestions and wish you a happy
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875022#comment-16875022
]
Erik Krogen commented on HDFS-14547:
[~LiJinglun], the new patch looks really good, I have a few more
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874920#comment-16874920
]
Hadoop QA commented on HDFS-14547:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874853#comment-16874853
]
Jinglun commented on HDFS-14547:
Hi [~xkrogen], thanks very much for your kind and detailed review. The
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874493#comment-16874493
]
Erik Krogen commented on HDFS-14547:
[~LiJinglun] I just took a look, thanks a lot for this work. It
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871395#comment-16871395
]
Erik Krogen commented on HDFS-14547:
Thanks for the ping, I will try to review this week
>
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869383#comment-16869383
]
Jinglun commented on HDFS-14547:
Hi [~xkrogen], do you mind to have a review at patch-005, thanks very
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865654#comment-16865654
]
He Xiaoqiao commented on HDFS-14547:
+1 for [^HDFS-14547.005.patch], Please pending [~xkrogen] give
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865304#comment-16865304
]
Hadoop QA commented on HDFS-14547:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865267#comment-16865267
]
Jinglun commented on HDFS-14547:
Hi [~hexiaoqiao], thanks for your reminding. After checking the
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865029#comment-16865029
]
He Xiaoqiao commented on HDFS-14547:
[~LiJinglun] Please notice report via HadoopQA.
{code:java}
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863912#comment-16863912
]
Hadoop QA commented on HDFS-14547:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863756#comment-16863756
]
Jinglun commented on HDFS-14547:
Thanks [~hexiaoqiao] for review and comments. Upload patch-004 following
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863705#comment-16863705
]
Hadoop QA commented on HDFS-14547:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863688#comment-16863688
]
He Xiaoqiao commented on HDFS-14547:
Thanks [~LiJinglun] for the great work.
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863078#comment-16863078
]
Hadoop QA commented on HDFS-14547:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863068#comment-16863068
]
Jinglun commented on HDFS-14547:
Upload the test report, will supplement the comments and license later.
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862316#comment-16862316
]
Hadoop QA commented on HDFS-14547:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862277#comment-16862277
]
Erik Krogen commented on HDFS-14547:
[~LiJinglun], thanks for taking this up, it seems like a
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862226#comment-16862226
]
He Xiaoqiao commented on HDFS-14547:
[~LiJinglun], Thanks for your ping.
just quick review
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862069#comment-16862069
]
Jinglun commented on HDFS-14547:
Hi [~jojochuang] [~xkrogen] [~hexiaoqiao], do you mind to review the
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861743#comment-16861743
]
Jinglun commented on HDFS-14547:
Does anybody have time to review the patch? Looking forward to all
[
https://issues.apache.org/jira/browse/HDFS-14547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861740#comment-16861740
]
Jinglun commented on HDFS-14547:
The EnumCounters is widely used in DirectoryWithQuotaFeature and quota
36 matches
Mail list logo