[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-07-16 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886134#comment-16886134 ] Ayush Saxena commented on HDFS-14577: - v001 LGTM +1 [~elgoiri] any further comments

[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-07-16 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886279#comment-16886279 ] Íñigo Goiri commented on HDFS-14577: [^HDFS-14577-HDFS-13891.001.patch] is good. The

[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-07-18 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888080#comment-16888080 ] Ayush Saxena commented on HDFS-14577: - So what we can do, Should we do as part of the

[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-07-18 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888224#comment-16888224 ] Íñigo Goiri commented on HDFS-14577: I think this is separate enough and can go in th

[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-07-18 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888241#comment-16888241 ] Ayush Saxena commented on HDFS-14577: - Thanx [~elgoiri] I have put the same patch aga

[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-07-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888283#comment-16888283 ] Hadoop QA commented on HDFS-14577: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-07-18 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888447#comment-16888447 ] Íñigo Goiri commented on HDFS-14577: [^HDFS-14577.001.patch] LGTM. The failed unit te

[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-07-19 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889147#comment-16889147 ] Hudson commented on HDFS-14577: --- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #

[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-06-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865959#comment-16865959 ] Hadoop QA commented on HDFS-14577: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-06-17 Thread CR Hota (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865969#comment-16865969 ] CR Hota commented on HDFS-14577: [~elgoiri] Could you please help take a look? > RBF: Fe

[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-06-17 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865980#comment-16865980 ] Íñigo Goiri commented on HDFS-14577: It seems reasonable. My only concern is with the

[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-06-17 Thread CR Hota (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866001#comment-16866001 ] CR Hota commented on HDFS-14577: [~elgoiri] Thanks for the review. ReflectionUtils is qu

[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-06-17 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866142#comment-16866142 ] Íñigo Goiri commented on HDFS-14577: It sounds reasonable. [~ayushtkn], do you mind t

[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-06-19 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867522#comment-16867522 ] Ayush Saxena commented on HDFS-14577: - The code change seems quite straightforward. B

[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-06-19 Thread CR Hota (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867800#comment-16867800 ] CR Hota commented on HDFS-14577: [~ayushtkn] Thanks for the review. Plan to use this cha

[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-06-20 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16868643#comment-16868643 ] Ayush Saxena commented on HDFS-14577: - Well isolation is, if it is completely unrelat

[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-06-20 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16868730#comment-16868730 ] Íñigo Goiri commented on HDFS-14577: Thanks [~ayushtkn] for checking. [~brahmareddy],

[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-06-20 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16868743#comment-16868743 ] Ayush Saxena commented on HDFS-14577: - Nopes, Not allowed now. > RBF: FederationUtil

[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context

2019-06-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16870543#comment-16870543 ] Hadoop QA commented on HDFS-14577: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote