[jira] [Commented] (HDFS-14579) In refreshNodes, avoid performing a DNS lookup while holding the write lock

2019-07-12 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884171#comment-16884171 ] Íñigo Goiri commented on HDFS-14579: [~sodonnell], yes I think the lock is fine. I th

[jira] [Commented] (HDFS-14579) In refreshNodes, avoid performing a DNS lookup while holding the write lock

2019-07-11 Thread He Xiaoqiao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883501#comment-16883501 ] He Xiaoqiao commented on HDFS-14579: Thanks [~sodonnell], {quote}I would suggest we r

[jira] [Commented] (HDFS-14579) In refreshNodes, avoid performing a DNS lookup while holding the write lock

2019-07-10 Thread Stephen O'Donnell (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881953#comment-16881953 ] Stephen O'Donnell commented on HDFS-14579: -- I think we concluded the 'slow DNS'

[jira] [Commented] (HDFS-14579) In refreshNodes, avoid performing a DNS lookup while holding the write lock

2019-06-19 Thread He Xiaoqiao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867902#comment-16867902 ] He Xiaoqiao commented on HDFS-14579: Sorry for the late comments. To [~sodonnell] {qu

[jira] [Commented] (HDFS-14579) In refreshNodes, avoid performing a DNS lookup while holding the write lock

2019-06-19 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867877#comment-16867877 ] Chao Sun commented on HDFS-14579: - One (not quite related) issue we've seen is that when

[jira] [Commented] (HDFS-14579) In refreshNodes, avoid performing a DNS lookup while holding the write lock

2019-06-19 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867863#comment-16867863 ] Íñigo Goiri commented on HDFS-14579: We tried in the past to improve the DNS caching

[jira] [Commented] (HDFS-14579) In refreshNodes, avoid performing a DNS lookup while holding the write lock

2019-06-19 Thread Stephen O'Donnell (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867849#comment-16867849 ] Stephen O'Donnell commented on HDFS-14579: -- [~kihwal] So that is 54ms for the re

[jira] [Commented] (HDFS-14579) In refreshNodes, avoid performing a DNS lookup while holding the write lock

2019-06-19 Thread Kihwal Lee (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867808#comment-16867808 ] Kihwal Lee commented on HDFS-14579: --- Loading include/exclude causes lookups unless the

[jira] [Commented] (HDFS-14579) In refreshNodes, avoid performing a DNS lookup while holding the write lock

2019-06-18 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867098#comment-16867098 ] Íñigo Goiri commented on HDFS-14579: Yes, refreshNodes is slightly different: {code}

[jira] [Commented] (HDFS-14579) In refreshNodes, avoid performing a DNS lookup while holding the write lock

2019-06-18 Thread Stephen O'Donnell (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867050#comment-16867050 ] Stephen O'Donnell commented on HDFS-14579: -- >From that stack trace, it looks lik

[jira] [Commented] (HDFS-14579) In refreshNodes, avoid performing a DNS lookup while holding the write lock

2019-06-18 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867011#comment-16867011 ] Íñigo Goiri commented on HDFS-14579: So here you can see this stuck at getting the ad

[jira] [Commented] (HDFS-14579) In refreshNodes, avoid performing a DNS lookup while holding the write lock

2019-06-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866679#comment-16866679 ] Hadoop QA commented on HDFS-14579: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14579) In refreshNodes, avoid performing a DNS lookup while holding the write lock

2019-06-18 Thread Stephen O'Donnell (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866659#comment-16866659 ] Stephen O'Donnell commented on HDFS-14579: -- Both [~hexiaoqiao] and [~elgoiri] sa

[jira] [Commented] (HDFS-14579) In refreshNodes, avoid performing a DNS lookup while holding the write lock

2019-06-18 Thread Kihwal Lee (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866612#comment-16866612 ] Kihwal Lee commented on HDFS-14579: --- {{node.getResolvedAddress()}} does not cause an ac