[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895280#comment-16895280 ] Wei-Chiu Chuang commented on HDFS-14632: Thanks for confirming. Cherry picked the commit into

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894242#comment-16894242 ] He Xiaoqiao commented on HDFS-14632: It is clean to cherry pick [^HDFS-14632.006.patch] to branch-3.2

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894205#comment-16894205 ] Wei-Chiu Chuang commented on HDFS-14632: I think this is safe to cherry pick into lower branches.

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881796#comment-16881796 ] He Xiaoqiao commented on HDFS-14632: Thanks [~linyiqun] for your reviews and help to commit. >

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881757#comment-16881757 ] Hudson commented on HDFS-14632: --- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16878 (See

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881687#comment-16881687 ] Yiqun Lin commented on HDFS-14632: -- LGTM, +1. Commit this shortly. > Reduce useless

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881363#comment-16881363 ] Hadoop QA commented on HDFS-14632: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881226#comment-16881226 ] He Xiaoqiao commented on HDFS-14632: [~linyiqun], Thanks, you are correct. [^HDFS-14632.006.patch]

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1688#comment-1688 ] Yiqun Lin commented on HDFS-14632: -- Almost looks great now, only two nits for the unit test: * Can we

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880995#comment-16880995 ] Hadoop QA commented on HDFS-14632: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880904#comment-16880904 ] He Xiaoqiao commented on HDFS-14632: Thanks [~linyiqun] for detailed comments. Get it and update

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880872#comment-16880872 ] Yiqun Lin commented on HDFS-14632: -- Thanks for updating the patch, [~hexiaoqiao]! Maybe my review

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880492#comment-16880492 ] Hadoop QA commented on HDFS-14632: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880334#comment-16880334 ] He Xiaoqiao commented on HDFS-14632: [~linyiqun], Thanks for your reviews. It seems that

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880116#comment-16880116 ] Yiqun Lin commented on HDFS-14632: -- Thanks for filling this, [~hexiaoqiao]. Some review comments from

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879006#comment-16879006 ] He Xiaoqiao commented on HDFS-14632: update patch [^HDFS-14632.003.patch] and fix checkstyle. Check

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879004#comment-16879004 ] Hadoop QA commented on HDFS-14632: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878995#comment-16878995 ] Hadoop QA commented on HDFS-14632: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878950#comment-16878950 ] He Xiaoqiao commented on HDFS-14632: upload new patch [^HDFS-14632.002.patch], fix failed test and

[jira] [Commented] (HDFS-14632) Reduce useless #getNumLiveDataNodes call in SafeModeMonitor

[ https://issues.apache.org/jira/browse/HDFS-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878853#comment-16878853 ] Hadoop QA commented on HDFS-14632: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||