[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973256#comment-16973256
]
Yiqun Lin commented on HDFS-14648:
--
LGTM, +1.
I will hold off the commit until the weekend in case
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973100#comment-16973100
]
Hadoop QA commented on HDFS-14648:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973039#comment-16973039
]
Hadoop QA commented on HDFS-14648:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973016#comment-16973016
]
Lisheng Sun commented on HDFS-14648:
i updated the patch and uploaded the v011 patch. Could you mind
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972994#comment-16972994
]
Yiqun Lin commented on HDFS-14648:
--
[~leosun08], sorry for the confused, you are right. Please remove
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972990#comment-16972990
]
Lisheng Sun commented on HDFS-14648:
hi [~linyiqun]
{quote}
DFSInputStream.java
I haven't seen the
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972980#comment-16972980
]
Yiqun Lin commented on HDFS-14648:
--
The latest patch looks great, some more comments:
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972735#comment-16972735
]
Hadoop QA commented on HDFS-14648:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972624#comment-16972624
]
Lisheng Sun commented on HDFS-14648:
Thanks [~linyiqun] for good comments.
i updated the patch as
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972571#comment-16972571
]
Yiqun Lin commented on HDFS-14648:
--
Thanks [~leosun08] , the patch almost looks good now, only some
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972566#comment-16972566
]
Hadoop QA commented on HDFS-14648:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972358#comment-16972358
]
Lisheng Sun commented on HDFS-14648:
{quote}
2) The line newDeadNodes.retainAll(deadNodes.values());
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972036#comment-16972036
]
Yiqun Lin commented on HDFS-14648:
--
Thanks [~leosun08] for updating the patch! It looks more readable
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971324#comment-16971324
]
Hadoop QA commented on HDFS-14648:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971280#comment-16971280
]
Lisheng Sun commented on HDFS-14648:
Thanks [~linyiqun] for deeply review and good commnets.
I
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971007#comment-16971007
]
Yiqun Lin commented on HDFS-14648:
--
The patch overall looks good, but some places seem not readable. I'd
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922317#comment-16922317
]
Lisheng Sun commented on HDFS-14648:
Detailed DeadNodeDetector desgin documents attached HDFS-13571.
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920062#comment-16920062
]
Hadoop QA commented on HDFS-14648:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918855#comment-16918855
]
Hadoop QA commented on HDFS-14648:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918707#comment-16918707
]
Lisheng Sun commented on HDFS-14648:
Thank [~hexiaoqiao] for deep reivew and good suggestion.
{quote}
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915281#comment-16915281
]
Lisheng Sun commented on HDFS-14648:
Thank [~zhangchen] for good suggestion. I will upload the a
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915262#comment-16915262
]
He Xiaoqiao commented on HDFS-14648:
Thanks [~leosun08] for your contributions. I try to learn
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915165#comment-16915165
]
Chen Zhang commented on HDFS-14648:
---
[~leosun08], since this is a big patch, I think it would be better
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915143#comment-16915143
]
Lisheng Sun commented on HDFS-14648:
Thank [~jojochuang] for your good suggetions. I updated the
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914760#comment-16914760
]
Duo Zhang commented on HDFS-14648:
--
We have been using this in our production for a long time. It does
[
https://issues.apache.org/jira/browse/HDFS-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914479#comment-16914479
]
Wei-Chiu Chuang commented on HDFS-14648:
[~leosun08] thanks for filing the jira. This appears
26 matches
Mail list logo
