[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924128#comment-16924128
]
Surendra Singh Lilhore commented on HDFS-14699:
---
Thanks [~zhaoyim] for path and [~ayushtkn]
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923574#comment-16923574
]
Ayush Saxena commented on HDFS-14699:
-
Thanx [~zhaoyim] for the patch.
v05 LGTM +1
> Erasure Coding:
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921048#comment-16921048
]
Hadoop QA commented on HDFS-14699:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920873#comment-16920873
]
Ayush Saxena commented on HDFS-14699:
-
Let me try once again to explain :
Say, I applied your patch
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920846#comment-16920846
]
Zhao Yi Ming commented on HDFS-14699:
-
[~ayushtkn] For The UT part, because I added the new test case
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920827#comment-16920827
]
Ayush Saxena commented on HDFS-14699:
-
[~zhaoyim] I am talking about the code. Let me try to be more
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920737#comment-16920737
]
Zhao Yi Ming commented on HDFS-14699:
-
[~ayushtkn] Thanks for your comments! And I am not sure what
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920346#comment-16920346
]
Ayush Saxena commented on HDFS-14699:
-
Thanx [~zhaoyim] for the patch. The UT passes without the fix
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918221#comment-16918221
]
Zhao Yi Ming commented on HDFS-14699:
-
[~ayushtkn] [~jojochuang] any updates on the code review?
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914963#comment-16914963
]
Zhao Yi Ming commented on HDFS-14699:
-
[~ayushtkn] Thanks for your review and comments! I fixed the
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914066#comment-16914066
]
Ayush Saxena commented on HDFS-14699:
-
Typo Here :
{code:java}
assertEquals("Chooes
{code}
Try
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913866#comment-16913866
]
Zhao Yi Ming commented on HDFS-14699:
-
[~jojochuang] could you have time to have a review on this
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913191#comment-16913191
]
Zhao Yi Ming commented on HDFS-14699:
-
style check passed. Submit PR:
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912998#comment-16912998
]
Hadoop QA commented on HDFS-14699:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912402#comment-16912402
]
Hadoop QA commented on HDFS-14699:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912212#comment-16912212
]
Zhao Yi Ming commented on HDFS-14699:
-
By the way, I did NOT submit a pr in the github, if you think
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911988#comment-16911988
]
Zhao Yi Ming commented on HDFS-14699:
-
[~ayushtkn] Thanks for reminder! I will provide another patch
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911743#comment-16911743
]
Hadoop QA commented on HDFS-14699:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911366#comment-16911366
]
Ayush Saxena commented on HDFS-14699:
-
Thanx [~zhaoyim] for the patch. Can you extend a UT for the
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911181#comment-16911181
]
Zhao Yi Ming commented on HDFS-14699:
-
[~jojochuang] Thanks a lot! I tried fix this issue, and
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911179#comment-16911179
]
Wei-Chiu Chuang commented on HDFS-14699:
[~zhaoyim] added you to the contributor list and
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911176#comment-16911176
]
Zhao Yi Ming commented on HDFS-14699:
-
Seems I can NOT assign this issue to me.
> Erasure Coding:
[
https://issues.apache.org/jira/browse/HDFS-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899744#comment-16899744
]
Zhao Yi Ming commented on HDFS-14699:
-
Maybe related with
23 matches
Mail list logo