[jira] [Commented] (HDFS-14810) Review FSNameSystem editlog sync

2019-10-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953914#comment-16953914 ] Hudson commented on HDFS-14810: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #

[jira] [Commented] (HDFS-14810) Review FSNameSystem editlog sync

2019-10-17 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953891#comment-16953891 ] Ayush Saxena commented on HDFS-14810: - Committed to trunk. Thanx [~hexiaoqiao] for th

[jira] [Commented] (HDFS-14810) Review FSNameSystem editlog sync

2019-10-15 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951694#comment-16951694 ] Ayush Saxena commented on HDFS-14810: - Will commit this tomorrow EOD, if no further c

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-29 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940660#comment-16940660 ] Xiaoqiao He commented on HDFS-14810: [~jojochuang] gentle reminder again. any update

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-24 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16936977#comment-16936977 ] Ayush Saxena commented on HDFS-14810: - [~jojochuang] gentle reminder, you promised to

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-11 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927827#comment-16927827 ] Ayush Saxena commented on HDFS-14810: - Hi [~jojochuang] Any update? > review FSNameS

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-08 Thread He Xiaoqiao (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16925320#comment-16925320 ] He Xiaoqiao commented on HDFS-14810: Hi [~jojochuang],[~ayushtkn] any update for this

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-06 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16924215#comment-16924215 ] Wei-Chiu Chuang commented on HDFS-14810: [~ayushtkn] i'm really sorry coming to t

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-05 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923565#comment-16923565 ] Ayush Saxena commented on HDFS-14810: - v004 LGTM +1, Will wait for a day, If [~jojoch

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-05 Thread He Xiaoqiao (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923173#comment-16923173 ] He Xiaoqiao commented on HDFS-14810: Check failed unit tests [TestNamenodeCapacityRep

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-05 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923115#comment-16923115 ] Hadoop QA commented on HDFS-14810: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-04 Thread He Xiaoqiao (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923035#comment-16923035 ] He Xiaoqiao commented on HDFS-14810: Thanks [~ayushtkn], [^HDFS-14810.004.patch] remo

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-04 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923006#comment-16923006 ] Ayush Saxena commented on HDFS-14810: - Thanx [~hexiaoqiao], I think we can remove the

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-04 Thread He Xiaoqiao (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922726#comment-16922726 ] He Xiaoqiao commented on HDFS-14810: [~ayushtkn],[~jojochuang],[~kihwal] do you mind

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-04 Thread He Xiaoqiao (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922692#comment-16922692 ] He Xiaoqiao commented on HDFS-14810: Thanks [~ayushtkn] for your nice reviews. 1. I t

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-04 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922553#comment-16922553 ] Ayush Saxena commented on HDFS-14810: - Thanx [~hexiaoqiao]  for the patch. {code:jav

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-02 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921004#comment-16921004 ] Hadoop QA commented on HDFS-14810: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-02 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921000#comment-16921000 ] Ayush Saxena commented on HDFS-14810: - Thanx [~hexiaoqiao] for confirming. [~jojochua

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-02 Thread He Xiaoqiao (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920981#comment-16920981 ] He Xiaoqiao commented on HDFS-14810: check four failed unit tests are all related wit

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-02 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920829#comment-16920829 ] Ayush Saxena commented on HDFS-14810: - Thanx [~hexiaoqiao] there are couple of failur

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-02 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920758#comment-16920758 ] Hadoop QA commented on HDFS-14810: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-02 Thread He Xiaoqiao (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920719#comment-16920719 ] He Xiaoqiao commented on HDFS-14810: [^HDFS-14810.003.patch] changes point based on v

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-01 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920636#comment-16920636 ] Ayush Saxena commented on HDFS-14810: - Thanx [~hexiaoqiao] for the patch, I think tha

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-01 Thread He Xiaoqiao (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920612#comment-16920612 ] He Xiaoqiao commented on HDFS-14810: [^HDFS-14810.002.patch] try to fix some exceptio

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-01 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920449#comment-16920449 ] Hadoop QA commented on HDFS-14810: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-01 Thread He Xiaoqiao (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920413#comment-16920413 ] He Xiaoqiao commented on HDFS-14810: Thanks [~ayushtkn] for your feedback, I will upd

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-01 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920407#comment-16920407 ] Ayush Saxena commented on HDFS-14810: - Thanx [~hexiaoqiao] I had a quick view of the

[jira] [Commented] (HDFS-14810) review FSNameSystem editlog sync

2019-09-01 Thread He Xiaoqiao (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920386#comment-16920386 ] He Xiaoqiao commented on HDFS-14810: some unnecessary edit logs such as HDFS-11291 re