[jira] [Commented] (HDFS-14936) Add getNumOfChildren() for interface InnerNode

[ https://issues.apache.org/jira/browse/HDFS-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964301#comment-16964301 ] Hudson commented on HDFS-14936: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17589 (See

[jira] [Commented] (HDFS-14936) Add getNumOfChildren() for interface InnerNode

[ https://issues.apache.org/jira/browse/HDFS-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964283#comment-16964283 ] Ayush Saxena commented on HDFS-14936: - Committed to trunk. Thanx [~leosun08] for the contribution

[jira] [Commented] (HDFS-14936) Add getNumOfChildren() for interface InnerNode

[ https://issues.apache.org/jira/browse/HDFS-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963641#comment-16963641 ] Ayush Saxena commented on HDFS-14936: - v003 LGTM +1 Will commit later today, if no further comments.

[jira] [Commented] (HDFS-14936) Add getNumOfChildren() for interface InnerNode

[ https://issues.apache.org/jira/browse/HDFS-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963567#comment-16963567 ] Lisheng Sun commented on HDFS-14936: hi [~elgoiri] [~ayushtkn] Should we commit this patch to trunk?

[jira] [Commented] (HDFS-14936) Add getNumOfChildren() for interface InnerNode

[ https://issues.apache.org/jira/browse/HDFS-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962294#comment-16962294 ] Íñigo Goiri commented on HDFS-14936: +1 on [^HDFS-14936.003.patch]. > Add getNumOfChildren() for

[jira] [Commented] (HDFS-14936) Add getNumOfChildren() for interface InnerNode

[ https://issues.apache.org/jira/browse/HDFS-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962117#comment-16962117 ] Hadoop QA commented on HDFS-14936: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14936) Add getNumOfChildren() for interface InnerNode

[ https://issues.apache.org/jira/browse/HDFS-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962090#comment-16962090 ] Siyao Meng commented on HDFS-14936: --- Thanks [~leosun08]. +1 on rev 003 > Add getNumOfChildren() for

[jira] [Commented] (HDFS-14936) Add getNumOfChildren() for interface InnerNode

[ https://issues.apache.org/jira/browse/HDFS-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961892#comment-16961892 ] Lisheng Sun commented on HDFS-14936: i updated UT and upload the v003 patch. Could you help review

[jira] [Commented] (HDFS-14936) Add getNumOfChildren() for interface InnerNode

[ https://issues.apache.org/jira/browse/HDFS-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961810#comment-16961810 ] Ayush Saxena commented on HDFS-14936: - we should check for non zero entry too in the test > Add

[jira] [Commented] (HDFS-14936) Add getNumOfChildren() for interface InnerNode

[ https://issues.apache.org/jira/browse/HDFS-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961700#comment-16961700 ] Hadoop QA commented on HDFS-14936: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14936) Add getNumOfChildren() for interface InnerNode

[ https://issues.apache.org/jira/browse/HDFS-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961606#comment-16961606 ] Lisheng Sun commented on HDFS-14936: Thanks[~elgoiri] for your suggestion. i add UT for this patch.

[jira] [Commented] (HDFS-14936) Add getNumOfChildren() for interface InnerNode

[ https://issues.apache.org/jira/browse/HDFS-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961275#comment-16961275 ] Íñigo Goiri commented on HDFS-14936: How is the test coverage for this? This is indirectly tested by

[jira] [Commented] (HDFS-14936) Add getNumOfChildren() for interface InnerNode

[ https://issues.apache.org/jira/browse/HDFS-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960994#comment-16960994 ] Ayush Saxena commented on HDFS-14936: - Seems OK. +1 Will commit by tomorrow, if no comments. > Add

[jira] [Commented] (HDFS-14936) Add getNumOfChildren() for interface InnerNode

[ https://issues.apache.org/jira/browse/HDFS-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960979#comment-16960979 ] Lisheng Sun commented on HDFS-14936: [~ayushtkn] all of subclasses of InnerNode as follow:

[jira] [Commented] (HDFS-14936) Add getNumOfChildren() for interface InnerNode

[ https://issues.apache.org/jira/browse/HDFS-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960969#comment-16960969 ] Hadoop QA commented on HDFS-14936: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14936) Add getNumOfChildren() for interface InnerNode

[ https://issues.apache.org/jira/browse/HDFS-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960940#comment-16960940 ] Ayush Saxena commented on HDFS-14936: - But InnerNode is extended not only by {{InnerNodeImpl}} and