[jira] [Commented] (HDFS-15263) Fix the logic of scope and excluded scope in Network Topology

2020-04-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078044#comment-17078044 ] Hudson commented on HDFS-15263: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #

[jira] [Commented] (HDFS-15263) Fix the logic of scope and excluded scope in Network Topology

2020-04-08 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078033#comment-17078033 ] Ayush Saxena commented on HDFS-15263: - Committed to trunk. Thanx [~elgoiri] for the

[jira] [Commented] (HDFS-15263) Fix the logic of scope and excluded scope in Network Topology

2020-04-07 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077520#comment-17077520 ] Íñigo Goiri commented on HDFS-15263: +1 on [^HDFS-15263-05.patch]. > Fix the logic

[jira] [Commented] (HDFS-15263) Fix the logic of scope and excluded scope in Network Topology

2020-04-07 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077389#comment-17077389 ] Ayush Saxena commented on HDFS-15263: - Thanx [~elgoiri] for the review. Checked {{Te

[jira] [Commented] (HDFS-15263) Fix the logic of scope and excluded scope in Network Topology

2020-04-07 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077363#comment-17077363 ] Íñigo Goiri commented on HDFS-15263: [^HDFS-15263-05.patch] LGTM. Do you mind checkin

[jira] [Commented] (HDFS-15263) Fix the logic of scope and excluded scope in Network Topology

2020-04-07 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077050#comment-17077050 ] Hadoop QA commented on HDFS-15263: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-15263) Fix the logic of scope and excluded scope in Network Topology

2020-04-06 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076617#comment-17076617 ] Íñigo Goiri commented on HDFS-15263: * For the appending PATH_SEPARATOR_STR to a new

[jira] [Commented] (HDFS-15263) Fix the logic of scope and excluded scope in Network Topology

2020-04-05 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075973#comment-17075973 ] Hadoop QA commented on HDFS-15263: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-15263) Fix the logic of scope and excluded scope in Network Topology

2020-04-05 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075917#comment-17075917 ] Ayush Saxena commented on HDFS-15263: - {quote}For appending PATH_SEPARATOR_STR, I was

[jira] [Commented] (HDFS-15263) Fix the logic of scope and excluded scope in Network Topology

2020-04-05 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075910#comment-17075910 ] Íñigo Goiri commented on HDFS-15263: * Yes, not sure what's a better name, at this po

[jira] [Commented] (HDFS-15263) Fix the logic of scope and excluded scope in Network Topology

2020-04-05 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075884#comment-17075884 ] Ayush Saxena commented on HDFS-15263: - Thanx [~elgoiri] for the review. bq. Is there

[jira] [Commented] (HDFS-15263) Fix the logic of scope and excluded scope in Network Topology

2020-04-05 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075874#comment-17075874 ] Íñigo Goiri commented on HDFS-15263: Thanks for the patch: * Can we add javadocs to t

[jira] [Commented] (HDFS-15263) Fix the logic of scope and excluded scope in Network Topology

2020-04-05 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075855#comment-17075855 ] Ayush Saxena commented on HDFS-15263: - Fixed Checkstyle > Fix the logic of scope and

[jira] [Commented] (HDFS-15263) Fix the logic of scope and excluded scope in Network Topology

2020-04-05 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075795#comment-17075795 ] Hadoop QA commented on HDFS-15263: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-15263) Fix the logic of scope and excluded scope in Network Topology

2020-04-05 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075790#comment-17075790 ] Hadoop QA commented on HDFS-15263: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote