[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-30 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149037#comment-17149037 ] Íñigo Goiri commented on HDFS-15410: +1 on [^HDFS-15410.005.patch]. > Add separated

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-30 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148662#comment-17148662 ] Hadoop QA commented on HDFS-15410: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-30 Thread Jinglun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148609#comment-17148609 ] Jinglun commented on HDFS-15410: Hi [~elgoiri], thanks your nice comments ! Rename fedba

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-29 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147999#comment-17147999 ] Íñigo Goiri commented on HDFS-15410: In addition to the keys, I was referring to call

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-29 Thread Yiqun Lin (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147742#comment-17147742 ] Yiqun Lin commented on HDFS-15410: -- [~inigoiri], would you mind to have a quick review f

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-28 Thread Jinglun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147511#comment-17147511 ] Jinglun commented on HDFS-15410: Hi [~linyiqun], shall we commit this ?:) > Add separate

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-22 Thread Yiqun Lin (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142164#comment-17142164 ] Yiqun Lin commented on HDFS-15410: -- LGTM , +1. [~elgoiri], Does the latest patch also l

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-22 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142115#comment-17142115 ] Hadoop QA commented on HDFS-15410: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-22 Thread Jinglun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142048#comment-17142048 ] Jinglun commented on HDFS-15410: Hi [~linyiqun],  thanks your nice comments ! Add more de

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-21 Thread Yiqun Lin (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141672#comment-17141672 ] Yiqun Lin commented on HDFS-15410: -- [~LiJinglun], one minor comment: can you add more de

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-20 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141132#comment-17141132 ] Hadoop QA commented on HDFS-15410: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-20 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141121#comment-17141121 ] Hadoop QA commented on HDFS-15410: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-20 Thread Jinglun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141109#comment-17141109 ] Jinglun commented on HDFS-15410: Hi [~linyiqun], thanks your nice comments ! {quote}Not f

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-20 Thread Jinglun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141104#comment-17141104 ] Jinglun commented on HDFS-15410: Hi [~elgoiri], thanks your nice comments ! {quote}What a

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-19 Thread Yiqun Lin (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140960#comment-17140960 ] Yiqun Lin commented on HDFS-15410: -- Besides [~elgoiri]'s review comment, some more reive

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-19 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140718#comment-17140718 ] Íñigo Goiri commented on HDFS-15410: We can fix the checkstyle. What about adding hdf

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-19 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140299#comment-17140299 ] Hadoop QA commented on HDFS-15410: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-18 Thread Jinglun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140240#comment-17140240 ] Jinglun commented on HDFS-15410: Hi [~elgoiri], thanks your nice comments ! Refer the fed

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-18 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139961#comment-17139961 ] Íñigo Goiri commented on HDFS-15410: I think we should refer to this in the documenta

[jira] [Commented] (HDFS-15410) Add separated config file fedbalance-default.xml for fedbalance tool

2020-06-18 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139216#comment-17139216 ] Hadoop QA commented on HDFS-15410: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote