[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198847#comment-17198847
]
Janus Chow commented on HDFS-15579:
---
[~elgoiri] [~ayushtkn] Thanks for the review.
> RBF: The
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198778#comment-17198778
]
Íñigo Goiri commented on HDFS-15579:
+1 on [^HDFS-15579-005.patch].
> RBF: The constructor of
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198761#comment-17198761
]
Ayush Saxena commented on HDFS-15579:
-
Test failure is unrelated.
v5 LGTM +1
> RBF: The constructor
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198754#comment-17198754
]
Janus Chow commented on HDFS-15579:
---
Another random failed unit test, should I create a new patch to
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198724#comment-17198724
]
Hadoop QA commented on HDFS-15579:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198709#comment-17198709
]
Hadoop QA commented on HDFS-15579:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198696#comment-17198696
]
Janus Chow commented on HDFS-15579:
---
Got it, resolved the checkstyle issues and added a test in
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198499#comment-17198499
]
Íñigo Goiri commented on HDFS-15579:
BTW, there are a few checkstyle issues in
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198497#comment-17198497
]
Íñigo Goiri commented on HDFS-15579:
If it is easy, it is usually best to have unit tests.
Otherwise,
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198406#comment-17198406
]
Janus Chow commented on HDFS-15579:
---
There was no tests for the class of PathLocation. Is it necessary
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198386#comment-17198386
]
Hadoop QA commented on HDFS-15579:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198266#comment-17198266
]
Janus Chow commented on HDFS-15579:
---
Thanks a lot, copied from v1.
> RBF: The constructor of
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198265#comment-17198265
]
Ayush Saxena commented on HDFS-15579:
-
Misses one param, there are two arguments, you missed the
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198152#comment-17198152
]
Janus Chow commented on HDFS-15579:
---
Checked the QA result was not be related to this patch.
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198106#comment-17198106
]
Hadoop QA commented on HDFS-15579:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198072#comment-17198072
]
Janus Chow commented on HDFS-15579:
---
Updated the static function version [^HDFS-15579-002.patch],
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197890#comment-17197890
]
Íñigo Goiri commented on HDFS-15579:
We should probably make this new method static right?
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197354#comment-17197354
]
Janus Chow commented on HDFS-15579:
---
Uploaded the patch, please have a check.
> RBF: The constructor
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197098#comment-17197098
]
Íñigo Goiri commented on HDFS-15579:
I think is something worth clarifying for sure.
Can you upload a
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196614#comment-17196614
]
Janus Chow commented on HDFS-15579:
---
There is already some instruction for this constructor.
[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196406#comment-17196406
]
Íñigo Goiri commented on HDFS-15579:
Yes, let's add a javadoc.
> RBF: The constructor of
21 matches
Mail list logo