[ https://issues.apache.org/jira/browse/HDFS-16174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400486#comment-17400486 ]
Íñigo Goiri commented on HDFS-16174: ------------------------------------ Thanks [~gautham] for the refactor. Merged PR 3303 to trunk. > Refactor TempFile and TempDir in libhdfs++ > ------------------------------------------ > > Key: HDFS-16174 > URL: https://issues.apache.org/jira/browse/HDFS-16174 > Project: Hadoop HDFS > Issue Type: Bug > Components: libhdfs++ > Affects Versions: 3.4.0 > Reporter: Gautham Banasandra > Assignee: Gautham Banasandra > Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > In C++, we generally do the declaration in the header files and the > corresponding implementation in the .cc files. Here we see that the > implementation of TempFile and TempDir are done in configuration_test.h > itself. This offers no benefit and the compilation of TempFile and TempDir > classes are duplicated for every #include of the configuration_test.h header. > Thus, we need to implement it in separate cc files to avoid this. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org