[
https://issues.apache.org/jira/browse/HDFS-17327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841224#comment-17841224
]
ASF GitHub Bot commented on HDFS-17327:
---------------------------------------
hadoop-yetus commented on PR #6421:
URL: https://github.com/apache/hadoop/pull/6421#issuecomment-2079381100
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 01s | | No case conflicting files
found. |
| +0 :ok: | spotbugs | 0m 00s | | spotbugs executables are not
available. |
| +0 :ok: | codespell | 0m 00s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 00s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 00s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 00s | | The patch appears to
include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 2m 19s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 85m 24s | | trunk passed |
| +1 :green_heart: | compile | 37m 18s | | trunk passed |
| +1 :green_heart: | checkstyle | 5m 36s | | trunk passed |
| -1 :x: | mvnsite | 4m 11s |
[/branch-mvnsite-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6421/1/artifact/out/branch-mvnsite-hadoop-common-project_hadoop-common.txt)
| hadoop-common in trunk failed. |
| +1 :green_heart: | javadoc | 10m 11s | | trunk passed |
| +1 :green_heart: | shadedclient | 153m 48s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 2m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 8m 55s | | the patch passed |
| +1 :green_heart: | compile | 34m 54s | | the patch passed |
| +1 :green_heart: | javac | 34m 54s | | the patch passed |
| +1 :green_heart: | blanks | 0m 00s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 5m 49s | | the patch passed |
| -1 :x: | mvnsite | 4m 12s |
[/patch-mvnsite-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6421/1/artifact/out/patch-mvnsite-hadoop-common-project_hadoop-common.txt)
| hadoop-common in the patch failed. |
| +1 :green_heart: | javadoc | 10m 20s | | the patch passed |
| +1 :green_heart: | shadedclient | 166m 40s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 5m 31s | | The patch does not
generate ASF License warnings. |
| | | 503m 26s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hadoop/pull/6421 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | MINGW64_NT-10.0-17763 33900c775089 3.4.10-87d57229.x86_64
2024-02-14 20:17 UTC x86_64 Msys |
| Build tool | maven |
| Personality | /c/hadoop/dev-support/bin/hadoop.sh |
| git revision | trunk / 2e2769ddf733bbaf154535f92d3d9dd6fa300f5c |
| Default Java | Azul Systems, Inc.-1.8.0_332-b09 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6421/1/testReport/
|
| modules | C: hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6421/1/console
|
| versions | git=2.44.0.windows.1 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
> Fix ReconfigurableBase class's reconfigureProperty method judgment logic.
> -------------------------------------------------------------------------
>
> Key: HDFS-17327
> URL: https://issues.apache.org/jira/browse/HDFS-17327
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Zhaobo Huang
> Assignee: Zhaobo Huang
> Priority: Major
> Labels: pull-request-available
>
> 1. If it is a null value, after reconfig, It may be that the current system
> value is in effect, not necessarily the default value.
> 2. {{ReconfigurableBase#reconfigureProperty}} judges the condition
> incorrectly, When the effectValue is not null, the system value needs to be
> changed.
> 3. In other words, certain variables actually have effected, but the current
> configuration of the system is refreshed to null.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
