[jira] [Commented] (HDFS-3643) hdfsJniHelper.c unchecked string pointers

2015-05-04 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527200#comment-14527200 ] Colin Patrick McCabe commented on HDFS-3643: We put braces around all "if" stat

[jira] [Commented] (HDFS-3643) hdfsJniHelper.c unchecked string pointers

2015-05-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525538#comment-14525538 ] Hadoop QA commented on HDFS-3643: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HDFS-3643) hdfsJniHelper.c unchecked string pointers

2012-10-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486535#comment-13486535 ] Hadoop QA commented on HDFS-3643: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (HDFS-3643) hdfsJniHelper.c unchecked string pointers

2012-10-29 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486432#comment-13486432 ] Todd Lipcon commented on HDFS-3643: --- That's only the case if the return type is a primiti

[jira] [Commented] (HDFS-3643) hdfsJniHelper.c unchecked string pointers

2012-10-29 Thread Andy Isaacson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486425#comment-13486425 ] Andy Isaacson commented on HDFS-3643: - bq. Wouldn't it be a string which comes from the

[jira] [Commented] (HDFS-3643) hdfsJniHelper.c unchecked string pointers

2012-10-29 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486399#comment-13486399 ] Todd Lipcon commented on HDFS-3643: --- {code} +else { +jthr = newRuntimeError(e

[jira] [Commented] (HDFS-3643) hdfsJniHelper.c unchecked string pointers

2012-08-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431439#comment-13431439 ] Hadoop QA commented on HDFS-3643: - -1 overall. Here are the results of testing the latest

[jira] [Commented] (HDFS-3643) hdfsJniHelper.c unchecked string pointers

2012-08-07 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430752#comment-13430752 ] Colin Patrick McCabe commented on HDFS-3643: I meant to write index(3).

[jira] [Commented] (HDFS-3643) hdfsJniHelper.c unchecked string pointers

2012-08-07 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430750#comment-13430750 ] Colin Patrick McCabe commented on HDFS-3643: Looks good in general. While you'

[jira] [Commented] (HDFS-3643) hdfsJniHelper.c unchecked string pointers

2012-07-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419704#comment-13419704 ] Hadoop QA commented on HDFS-3643: - -1 overall. Here are the results of testing the latest