[ https://issues.apache.org/jira/browse/HDFS-3899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451012#comment-13451012 ]
Aaron T. Myers commented on HDFS-3899: -------------------------------------- Patch looks pretty good to me. Just one small comment. +1 otherwise: # I find this comment kind of confusing, since these metrics are actually being measured and published on the "client" (NN) side: "The server-side metrics for a journal from the writer's perspective." > QJM: Writer-side metrics > ------------------------ > > Key: HDFS-3899 > URL: https://issues.apache.org/jira/browse/HDFS-3899 > Project: Hadoop HDFS > Issue Type: Sub-task > Affects Versions: QuorumJournalManager (HDFS-3077) > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Attachments: hdfs-3899.txt > > > We already have some metrics on the server side (JournalNode) but it's useful > to also gather metrics from the client side (NameNode). This is important in > order to monitor that the client is seeing good performance from the > individual JNs, and so that administrators can set up alerts if any of the > JNs has become inaccessible to the NN. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira