[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536610#comment-13536610
]
Andy Isaacson commented on HDFS-4140:
-
bq. Andy: it seems to me like Colin's latest pat
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534898#comment-13534898
]
Hudson commented on HDFS-4140:
--
Integrated in Hadoop-Mapreduce-trunk #1289 (See
[https://buil
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534873#comment-13534873
]
Hudson commented on HDFS-4140:
--
Integrated in Hadoop-Hdfs-trunk #1258 (See
[https://builds.ap
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534825#comment-13534825
]
Hudson commented on HDFS-4140:
--
Integrated in Hadoop-Yarn-trunk #69 (See
[https://builds.apac
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534582#comment-13534582
]
Hudson commented on HDFS-4140:
--
Integrated in Hadoop-trunk-Commit #3133 (See
[https://builds.
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534554#comment-13534554
]
Aaron T. Myers commented on HDFS-4140:
--
+1, the latest patch looks good to me. I think
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534552#comment-13534552
]
Colin Patrick McCabe commented on HDFS-4140:
I added a comment for the {{mSize
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532152#comment-13532152
]
Hadoop QA commented on HDFS-4140:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532070#comment-13532070
]
Hadoop QA commented on HDFS-4140:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531939#comment-13531939
]
Andy Isaacson commented on HDFS-4140:
-
interdiff says:
{code}
@@ -62,7 +62,9 @@
}
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530768#comment-13530768
]
Aaron T. Myers commented on HDFS-4140:
--
Thanks for cleaning up that code for clarity.
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530521#comment-13530521
]
Hadoop QA commented on HDFS-4140:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530473#comment-13530473
]
Andy Isaacson commented on HDFS-4140:
-
I like the cleanup, that part LGTM.
I somewhat
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528212#comment-13528212
]
Andy Isaacson commented on HDFS-4140:
-
Agreed the TestEditLog failure is unrelated.
+1
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511161#comment-13511161
]
Colin Patrick McCabe commented on HDFS-4140:
The test failure is bogus; we didn
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511044#comment-13511044
]
Hadoop QA commented on HDFS-4140:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510862#comment-13510862
]
Andy Isaacson commented on HDFS-4140:
-
LGTM, thanks for the cleanup!
+1 pending jenkins
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510200#comment-13510200
]
Andy Isaacson commented on HDFS-4140:
-
Thanks for the cleanup in .005, Colin. The new
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495565#comment-13495565
]
Andy Isaacson commented on HDFS-4140:
-
LGTM, +1.
> fuse-dfs handles op
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493713#comment-13493713
]
Hadoop QA commented on HDFS-4140:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493668#comment-13493668
]
Colin Patrick McCabe commented on HDFS-4140:
OK, I misinterpreted your comment
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493545#comment-13493545
]
Andy Isaacson commented on HDFS-4140:
-
bq. provides correct semantics up until the poin
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493501#comment-13493501
]
Colin Patrick McCabe commented on HDFS-4140:
Using {{flags |= O_APPEND}} provid
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493474#comment-13493474
]
Andy Isaacson commented on HDFS-4140:
-
(user error truncated comment)
... Opening {{O_
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493470#comment-13493470
]
Andy Isaacson commented on HDFS-4140:
-
bq. Do you have an idea for how to solve this pr
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493429#comment-13493429
]
Colin Patrick McCabe commented on HDFS-4140:
I will add a reference to the JIRA
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493393#comment-13493393
]
Andy Isaacson commented on HDFS-4140:
-
{code}
+ // The file exists, and has non-ze
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492115#comment-13492115
]
Hadoop QA commented on HDFS-4140:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492084#comment-13492084
]
Colin Patrick McCabe commented on HDFS-4140:
dfs_open: Fix memory leak resultin
29 matches
Mail list logo
