[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2015-05-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14524859#comment-14524859 ] Hadoop QA commented on HDFS-4504: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2015-05-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14524893#comment-14524893 ] Hadoop QA commented on HDFS-4504: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2014-07-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14056945#comment-14056945 ] Hadoop QA commented on HDFS-4504: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2014-02-25 Thread Fengdong Yu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13912360#comment-13912360 ] Fengdong Yu commented on HDFS-4504: --- [~cmccabe] this was opened for a long time. please

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2014-02-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13912475#comment-13912475 ] Hadoop QA commented on HDFS-4504: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13749660#comment-13749660 ] Hadoop QA commented on HDFS-4504: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-22 Thread Uma Maheswara Rao G (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13747288#comment-13747288 ] Uma Maheswara Rao G commented on HDFS-4504: --- {quote} Thanks for thinking of this.

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-21 Thread Uma Maheswara Rao G (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745848#comment-13745848 ] Uma Maheswara Rao G commented on HDFS-4504: --- Looks like this is good problem

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-21 Thread Vinay (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745868#comment-13745868 ] Vinay commented on HDFS-4504: - {quote}A DFSOutputStream is a zombie for one of two reasons: 1.

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-21 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13746907#comment-13746907 ] Colin Patrick McCabe commented on HDFS-4504: Thanks for thinking of this. Let

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-20 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745691#comment-13745691 ] Colin Patrick McCabe commented on HDFS-4504: Vinay wrote: bq. While handling

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-20 Thread Vinay (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745804#comment-13745804 ] Vinay commented on HDFS-4504: - Please check this test {code:java} @Test public void

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-19 Thread Uma Maheswara Rao G (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13743586#comment-13743586 ] Uma Maheswara Rao G commented on HDFS-4504: --- Hi Colin, Nice work on this issue.

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-19 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13744144#comment-13744144 ] Colin Patrick McCabe commented on HDFS-4504: bq. In the latest patch, some

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-19 Thread Vinay (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13744704#comment-13744704 ] Vinay commented on HDFS-4504: - {quote}In a lot of cases when close fails, the NameNode is not

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-18 Thread Vinay (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13743546#comment-13743546 ] Vinay commented on HDFS-4504: - In the latest patch, some unnecessary (Only space) file changes

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-15 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13741480#comment-13741480 ] Colin Patrick McCabe commented on HDFS-4504: A few tests needed to be fixed,

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13741676#comment-13741676 ] Hadoop QA commented on HDFS-4504: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-14 Thread Vinay (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13739288#comment-13739288 ] Vinay commented on HDFS-4504: - bq. It seems to me like it would be better to call

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-14 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13739293#comment-13739293 ] Colin Patrick McCabe commented on HDFS-4504: I don't think adding a new RPC

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-14 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13740434#comment-13740434 ] Colin Patrick McCabe commented on HDFS-4504: The latest patch: * when reaping

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13740546#comment-13740546 ] Hadoop QA commented on HDFS-4504: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-13 Thread Vinay (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13738134#comment-13738134 ] Vinay commented on HDFS-4504: - {quote}In some cases, DFSOutputStream#close and

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-13 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13738646#comment-13738646 ] Colin Patrick McCabe commented on HDFS-4504: You're right-- we're going to need

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1373#comment-1373 ] Hadoop QA commented on HDFS-4504: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-13 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13739162#comment-13739162 ] Colin Patrick McCabe commented on HDFS-4504: It looks like there are a few more

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-13 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13739168#comment-13739168 ] Todd Lipcon commented on HDFS-4504: --- I don't think {{recoverLease}} is the right API

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-13 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13739204#comment-13739204 ] Colin Patrick McCabe commented on HDFS-4504: The problem with calling

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-13 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13739215#comment-13739215 ] Colin Patrick McCabe commented on HDFS-4504: OK, I thought about this a little

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-12 Thread Vinay (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736680#comment-13736680 ] Vinay commented on HDFS-4504: - {quote}DFSOutputStream#close can throw an IOException in some

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-12 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736859#comment-13736859 ] Jason Lowe commented on HDFS-4504: -- There was a build failure in the test build because

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13737219#comment-13737219 ] Hadoop QA commented on HDFS-4504: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-12 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13737627#comment-13737627 ] Andrew Wang commented on HDFS-4504: --- Some light review comments, I'd prefer if someone

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-12 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13737737#comment-13737737 ] Colin Patrick McCabe commented on HDFS-4504: bq. TreeMaps are memory

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735594#comment-13735594 ] Hadoop QA commented on HDFS-4504: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13734281#comment-13734281 ] Hadoop QA commented on HDFS-4504: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-08-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13734380#comment-13734380 ] Hadoop QA commented on HDFS-4504: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-07-02 Thread Uma Maheswara Rao G (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13697624#comment-13697624 ] Uma Maheswara Rao G commented on HDFS-4504: --- Thanks Colin, for working on this

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-07-02 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13698487#comment-13698487 ] Colin Patrick McCabe commented on HDFS-4504: That's an interesting idea--

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-05-29 Thread Kihwal Lee (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669636#comment-13669636 ] Kihwal Lee commented on HDFS-4504: -- If the datanodes didn't get the last packet of the

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-05-29 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669684#comment-13669684 ] Colin Patrick McCabe commented on HDFS-4504: I think the vast majority of these

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-04-24 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13640937#comment-13640937 ] Todd Lipcon commented on HDFS-4504: --- Does this fully solve the problem, given that leases

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-04-24 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13640985#comment-13640985 ] Colin Patrick McCabe commented on HDFS-4504: bq. Does this fully solve the

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-04-18 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13635672#comment-13635672 ] Colin Patrick McCabe commented on HDFS-4504: bq. RPC retry should be done in

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-04-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13635834#comment-13635834 ] Hadoop QA commented on HDFS-4504: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-04-17 Thread Tsz Wo (Nicholas), SZE (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13634686#comment-13634686 ] Tsz Wo (Nicholas), SZE commented on HDFS-4504: -- We should retry the complete

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-04-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13634733#comment-13634733 ] Hadoop QA commented on HDFS-4504: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-02-14 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13578996#comment-13578996 ] Colin Patrick McCabe commented on HDFS-4504: Here is the code for

[jira] [Commented] (HDFS-4504) DFSOutputStream#close doesn't always release resources (such as leases)

2013-02-14 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13578998#comment-13578998 ] Colin Patrick McCabe commented on HDFS-4504: Another issue we could hit here is