[ https://issues.apache.org/jira/browse/HDFS-4627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13612613#comment-13612613 ]
Hudson commented on HDFS-4627: ------------------------------ Integrated in Hadoop-Hdfs-Snapshots-Branch-build #140 (See [https://builds.apache.org/job/Hadoop-Hdfs-Snapshots-Branch-build/140/]) HDFS-4627. Fix FSImageFormat#Loader NPE and synchronization issues. Contributed by Jing Zhao. (Revision 1460389) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1460389 Files : * /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-2802.txt * /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormat.java * /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSImageWithSnapshot.java > Fix FSImageFormat#Loader NPE and synchronization issues > ------------------------------------------------------- > > Key: HDFS-4627 > URL: https://issues.apache.org/jira/browse/HDFS-4627 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Reporter: Jing Zhao > Assignee: Jing Zhao > Fix For: Snapshot (HDFS-2802) > > Attachments: HDFS-4627.001.patch, HDFS-4627.002.patch > > > 1. Currently FSImageFormat#Loader#loadFilesUnderConstruction calls > FSDirectory#unprotectedReplaceINodeFile without acquiring FSDirectory's lock. > FSDirectory#replaceINodeFile should be called instead. > 2. Currently FSImage#Loader#loadINode does not create block[] object (i.e., > keep it as null) when the length of the block is 0. This will cause NPE when > the loaded INodeFile is empty, and then an append operation on this inode is > applied from edit log. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira