[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844268#comment-13844268
]
Hudson commented on HDFS-4983:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #1608 (See
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844303#comment-13844303
]
Hudson commented on HDFS-4983:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1634 (See
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843218#comment-13843218
]
Daryn Sharp commented on HDFS-4983:
---
I've questioned the necessity of this pattern before
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843292#comment-13843292
]
Yongjun Zhang commented on HDFS-4983:
-
Hi Daryn,
Please see the comment Alejandro
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843836#comment-13843836
]
Andrew Wang commented on HDFS-4983:
---
+1 looks good to me, thanks Yongjun. Typically we
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843873#comment-13843873
]
Hudson commented on HDFS-4983:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #4857 (See
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843932#comment-13843932
]
Yongjun Zhang commented on HDFS-4983:
-
Thanks a lot Andrew!
Numeric usernames do not
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842475#comment-13842475
]
Hudson commented on HDFS-4983:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #415 (See
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842504#comment-13842504
]
Hudson commented on HDFS-4983:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #1606 (See
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842522#comment-13842522
]
Hudson commented on HDFS-4983:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1632 (See
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842149#comment-13842149
]
Hadoop QA commented on HDFS-4983:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842329#comment-13842329
]
Hudson commented on HDFS-4983:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #4849 (See
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842399#comment-13842399
]
Yongjun Zhang commented on HDFS-4983:
-
Thanks a lot Jing! and many thanks to you all!
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841360#comment-13841360
]
Yongjun Zhang commented on HDFS-4983:
-
Thanks a lot Andrew, just uploaded a version
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841482#comment-13841482
]
Hadoop QA commented on HDFS-4983:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841508#comment-13841508
]
Jing Zhao commented on HDFS-4983:
-
+1 for the new patch. Thanks Yongjun!
Numeric
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841537#comment-13841537
]
Haohui Mai commented on HDFS-4983:
--
Good patch. A couple comments:
{code}
+ static {
+
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841560#comment-13841560
]
Haohui Mai commented on HDFS-4983:
--
Sorry, I didn't see userPattern is a static field. To
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841597#comment-13841597
]
Yongjun Zhang commented on HDFS-4983:
-
Many thanks to you all for the reviews and
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841655#comment-13841655
]
Haohui Mai commented on HDFS-4983:
--
bq. About the static block, the intention is that it
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841947#comment-13841947
]
Yongjun Zhang commented on HDFS-4983:
-
HI Haohui,
Many thanks for the comments. I just
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841991#comment-13841991
]
Haohui Mai commented on HDFS-4983:
--
+1. Thanks [~yzhangal]!
Numeric usernames do not
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842054#comment-13842054
]
Hadoop QA commented on HDFS-4983:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842105#comment-13842105
]
Yongjun Zhang commented on HDFS-4983:
-
Thanks Haohui.
I suspect the above test failure
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13840019#comment-13840019
]
Hudson commented on HDFS-4983:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #412 (See
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13840081#comment-13840081
]
Hudson commented on HDFS-4983:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #1603 (See
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13840120#comment-13840120
]
Hudson commented on HDFS-4983:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1629 (See
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13840596#comment-13840596
]
Jing Zhao commented on HDFS-4983:
-
bq. How about Yongjun revs his patch again based on your
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13840597#comment-13840597
]
Haohui Mai commented on HDFS-4983:
--
[~andrew.wang], this sounds good to me. Let's move
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13840653#comment-13840653
]
Yongjun Zhang commented on HDFS-4983:
-
Many thanks to all. I just uploaded a new
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13840756#comment-13840756
]
Hadoop QA commented on HDFS-4983:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13840860#comment-13840860
]
Andrew Wang commented on HDFS-4983:
---
Looks good Yongjun, +1 once this little nit is
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838719#comment-13838719
]
Fengdong Yu commented on HDFS-4983:
---
[~yzhangal] :
Thanks for fix, but I still have
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838756#comment-13838756
]
Hadoop QA commented on HDFS-4983:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839039#comment-13839039
]
Yongjun Zhang commented on HDFS-4983:
-
He Fengdong,
The fix is not trying to change
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839283#comment-13839283
]
Fengdong Yu commented on HDFS-4983:
---
OH, Thanks for clarification.
Numeric usernames
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839297#comment-13839297
]
Yongjun Zhang commented on HDFS-4983:
-
Sure Fengdong, I assume you are ok with my last
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839338#comment-13839338
]
Fengdong Yu commented on HDFS-4983:
---
yes, ok for me.
Numeric usernames do not work with
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839381#comment-13839381
]
Yongjun Zhang commented on HDFS-4983:
-
Thanks.
Numeric usernames do not work with
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839391#comment-13839391
]
Andrew Wang commented on HDFS-4983:
---
+1 looks good to me. As a future note, we don't wrap
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839394#comment-13839394
]
Haohui Mai commented on HDFS-4983:
--
I don't think the pattern should be configurable. I
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839411#comment-13839411
]
Jing Zhao commented on HDFS-4983:
-
I also think we do not need to make it configurable
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839422#comment-13839422
]
Hudson commented on HDFS-4983:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #4828 (See
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839426#comment-13839426
]
Andrew Wang commented on HDFS-4983:
---
Committed this to trunk and branch-2 after a few
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839424#comment-13839424
]
Colin Patrick McCabe commented on HDFS-4983:
bq. I also think we do not need to
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839433#comment-13839433
]
Colin Patrick McCabe commented on HDFS-4983:
ignore my previous comment about
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839436#comment-13839436
]
Andrew Wang commented on HDFS-4983:
---
Jing and Haohui, sorry that I missed your comments
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839434#comment-13839434
]
Jing Zhao commented on HDFS-4983:
-
bq. whereas webHDFS (despite the name) exists only in
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839438#comment-13839438
]
Jing Zhao commented on HDFS-4983:
-
bq. Should we open a follow-up JIRA to move the config
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839463#comment-13839463
]
Yongjun Zhang commented on HDFS-4983:
-
Thank you all. Before I introduce the new file
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839481#comment-13839481
]
Colin Patrick McCabe commented on HDFS-4983:
bq. At the end of the day both of
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839499#comment-13839499
]
Haohui Mai commented on HDFS-4983:
--
bq. I did a quick search, but wasn't able to find any
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839514#comment-13839514
]
Andrew Wang commented on HDFS-4983:
---
Folks, I'm just going to revert this out since it'd
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839526#comment-13839526
]
Jing Zhao commented on HDFS-4983:
-
bq. Let's figure out the right answer here.
Thanks
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839528#comment-13839528
]
Haohui Mai commented on HDFS-4983:
--
Jing's proposal should allow us to fix this in 2.3. +1
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839532#comment-13839532
]
Hudson commented on HDFS-4983:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #4829 (See
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839544#comment-13839544
]
Andrew Wang commented on HDFS-4983:
---
I'd kind of like to hear from [~qwertymaniac] as the
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839547#comment-13839547
]
Haohui Mai commented on HDFS-4983:
--
Here is a link that shows how adduser addresses this:
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839630#comment-13839630
]
Alejandro Abdelnur commented on HDFS-4983:
--
Allowed usernames are the OS allowed
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839674#comment-13839674
]
Harsh J commented on HDFS-4983:
---
Yes I requested a configurability for the same reason as
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839757#comment-13839757
]
Haohui Mai commented on HDFS-4983:
--
[~qwertymaniac], let's focus on supporting numeric
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839784#comment-13839784
]
Yongjun Zhang commented on HDFS-4983:
-
Thanks all for the discussion and comments.
My
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839801#comment-13839801
]
Haohui Mai commented on HDFS-4983:
--
My concern is why the flexibility is required in
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839845#comment-13839845
]
Harsh J commented on HDFS-4983:
---
bq. For example, what does it mean if I making this
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839873#comment-13839873
]
Haohui Mai commented on HDFS-4983:
--
bq. I disagree but as you wish. I simply do not want a
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838019#comment-13838019
]
Andrew Wang commented on HDFS-4983:
---
Hey Yongjun, thanks for providing the patch. A few
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838544#comment-13838544
]
Yongjun Zhang commented on HDFS-4983:
-
HI Andrew,
Thanks a lot for the review and
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838559#comment-13838559
]
Fengdong Yu commented on HDFS-4983:
---
Hi [~yzhangal] ,
We often limit 80 characters one
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838608#comment-13838608
]
Hadoop QA commented on HDFS-4983:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838672#comment-13838672
]
Yongjun Zhang commented on HDFS-4983:
-
Many thanks to Fengdong for the review and
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13713815#comment-13713815
]
Kousuke Saruta commented on HDFS-4983:
--
Hi Harsh,
I understood what you said.
It
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712115#comment-13712115
]
Kousuke Saruta commented on HDFS-4983:
--
Hi Harsh,
I think the reason is that
[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712172#comment-13712172
]
Harsh J commented on HDFS-4983:
---
Hi Kousuke,
Thanks for looking into this!
If you mean
73 matches
Mail list logo
