[
https://issues.apache.org/jira/browse/HDFS-5053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767142#comment-13767142
]
Colin Patrick McCabe commented on HDFS-5053:
CacheReplicationManager -- add loc
[
https://issues.apache.org/jira/browse/HDFS-5053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767131#comment-13767131
]
Colin Patrick McCabe commented on HDFS-5053:
bq. Renamed the config option to "
[
https://issues.apache.org/jira/browse/HDFS-5053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763762#comment-13763762
]
Todd Lipcon commented on HDFS-5053:
---
I did my review by loading the patch into my IDE and
[
https://issues.apache.org/jira/browse/HDFS-5053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763529#comment-13763529
]
Colin Patrick McCabe commented on HDFS-5053:
Looks good overall. My first impr
[
https://issues.apache.org/jira/browse/HDFS-5053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13738953#comment-13738953
]
Colin Patrick McCabe commented on HDFS-5053:
Let's remember to make these style
[
https://issues.apache.org/jira/browse/HDFS-5053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13738748#comment-13738748
]
Colin Patrick McCabe commented on HDFS-5053:
You are correct-- mlock is an impl
