[jira] [Commented] (HDFS-5448) Datanode should generate its ID on first registration

2013-11-05 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814555#comment-13814555 ] Arpit Agarwal commented on HDFS-5448: - Thanks for the correction, you're right.

[jira] [Commented] (HDFS-5448) Datanode should generate its ID on first registration

2013-11-04 Thread Eric Sirianni (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812838#comment-13812838 ] Eric Sirianni commented on HDFS-5448: - bq. Eric Sirianni, I believe this is not very

[jira] [Commented] (HDFS-5448) Datanode should generate its ID on first registration

2013-11-04 Thread Eric Sirianni (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812914#comment-13812914 ] Eric Sirianni commented on HDFS-5448: - Arpit - I think your patch causes a compile

[jira] [Commented] (HDFS-5448) Datanode should generate its ID on first registration

2013-11-04 Thread Eric Sirianni (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812933#comment-13812933 ] Eric Sirianni commented on HDFS-5448: - +1 patch looks good. I made the same change in

[jira] [Commented] (HDFS-5448) Datanode should generate its ID on first registration

2013-11-04 Thread Eric Sirianni (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812962#comment-13812962 ] Eric Sirianni commented on HDFS-5448: - Arpit - thanks for the change. The current

[jira] [Commented] (HDFS-5448) Datanode should generate its ID on first registration

2013-11-04 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812982#comment-13812982 ] Arpit Agarwal commented on HDFS-5448: - Eric, let's discuss this on a separate Jira that

[jira] [Commented] (HDFS-5448) Datanode should generate its ID on first registration

2013-11-04 Thread Eric Sirianni (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812989#comment-13812989 ] Eric Sirianni commented on HDFS-5448: - Actually, rather than having a potentially

[jira] [Commented] (HDFS-5448) Datanode should generate its ID on first registration

2013-11-04 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813501#comment-13813501 ] Konstantin Shvachko commented on HDFS-5448: --- Prior to the heterogeneous storage

[jira] [Commented] (HDFS-5448) Datanode should generate its ID on first registration

2013-11-04 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813511#comment-13813511 ] Arpit Agarwal commented on HDFS-5448: - storageID was generated by the NameNode in

[jira] [Commented] (HDFS-5448) Datanode should generate its ID on first registration

2013-11-04 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813734#comment-13813734 ] Konstantin Shvachko commented on HDFS-5448: --- Ah yes, this is a legacy and pretty