[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844118#comment-13844118
]
Hadoop QA commented on HDFS-5594:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844035#comment-13844035
]
Hadoop QA commented on HDFS-5594:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843820#comment-13843820
]
Vinay commented on HDFS-5594:
-
Hi Chris, latest patch looks great. +1
I have some small concer
[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843685#comment-13843685
]
Hadoop QA commented on HDFS-5594:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843620#comment-13843620
]
Hadoop QA commented on HDFS-5594:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843599#comment-13843599
]
Haohui Mai commented on HDFS-5594:
--
btw, there're a couple whitespace in the new patch, al
[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843457#comment-13843457
]
Haohui Mai commented on HDFS-5594:
--
bq. By including the perms in AclEntry#equals and AclE
[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843445#comment-13843445
]
Chris Nauroth commented on HDFS-5594:
-
Thanks for taking a look, Haohui.
bq. Why Acl#e
[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843436#comment-13843436
]
Haohui Mai commented on HDFS-5594:
--
BTW, it seems there're trailing whitespace in the patc
[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843417#comment-13843417
]
Haohui Mai commented on HDFS-5594:
--
The patch looks good to me overall. I have two minor c
[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842953#comment-13842953
]
Vinay commented on HDFS-5594:
-
+1, Latest changes looks fine Chris.
I am ok to keep subtasks u
[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842351#comment-13842351
]
Hadoop QA commented on HDFS-5594:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842305#comment-13842305
]
Chris Nauroth commented on HDFS-5594:
-
FYI, I think I've got one more version of this p
[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842257#comment-13842257
]
Chris Nauroth commented on HDFS-5594:
-
Vinay, thanks for looking at the patch.
It look
[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842253#comment-13842253
]
Vinay commented on HDFS-5594:
-
Thanks Chris for the patch.
Patch looks good to me.
My only conc
[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841501#comment-13841501
]
Hadoop QA commented on HDFS-5594:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841076#comment-13841076
]
Hadoop QA commented on HDFS-5594:
-
{color:red}-1 overall{color}. Here are the results of t
17 matches
Mail list logo