[jira] [Commented] (HDFS-5673) Implement logic for modification of ACLs.

[ https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863674#comment-13863674 ] Haohui Mai commented on HDFS-5673: -- okay. I think the patch looks good then. +1. > Implem

[jira] [Commented] (HDFS-5673) Implement logic for modification of ACLs.

[ https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863671#comment-13863671 ] Chris Nauroth commented on HDFS-5673: - bq. It might be worthwhile to add the check in c

[jira] [Commented] (HDFS-5673) Implement logic for modification of ACLs.

[ https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863586#comment-13863586 ] Haohui Mai commented on HDFS-5673: -- bq. If that happens, then the whole request would get

[jira] [Commented] (HDFS-5673) Implement logic for modification of ACLs.

[ https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863519#comment-13863519 ] Chris Nauroth commented on HDFS-5673: - bq. I wonder whether userEntry will be assigned

[jira] [Commented] (HDFS-5673) Implement logic for modification of ACLs.

[ https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863478#comment-13863478 ] Haohui Mai commented on HDFS-5673: -- for {{promoteDefaultEntries}} and {{calculateMask}}, w

[jira] [Commented] (HDFS-5673) Implement logic for modification of ACLs.

[ https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863420#comment-13863420 ] Chris Nauroth commented on HDFS-5673: - I just realized that the proposed pseudo-code fo

[jira] [Commented] (HDFS-5673) Implement logic for modification of ACLs.

[ https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863358#comment-13863358 ] Chris Nauroth commented on HDFS-5673: - Thanks, Haohui. In that case, let's work toward

[jira] [Commented] (HDFS-5673) Implement logic for modification of ACLs.

[ https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858998#comment-13858998 ] Haohui Mai commented on HDFS-5673: -- Thanks Chris. The latest version is much more readable

[jira] [Commented] (HDFS-5673) Implement logic for modification of ACLs.

[ https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855967#comment-13855967 ] Chris Nauroth commented on HDFS-5673: - Actually, the required functionality has a lot o

[jira] [Commented] (HDFS-5673) Implement logic for modification of ACLs.

[ https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855934#comment-13855934 ] Haohui Mai commented on HDFS-5673: -- Thanks Chris. On a high level, I would like to see th

[jira] [Commented] (HDFS-5673) Implement logic for modification of ACLs.

[ https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13854463#comment-13854463 ] Chris Nauroth commented on HDFS-5673: - Looking at the current state of HDFS-5618 and HD

[jira] [Commented] (HDFS-5673) Implement logic for modification of ACLs.

[ https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853164#comment-13853164 ] Haohui Mai commented on HDFS-5673: -- bq. If we don't copy the list, then the immutability g

[jira] [Commented] (HDFS-5673) Implement logic for modification of ACLs.

[ https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852409#comment-13852409 ] Chris Nauroth commented on HDFS-5673: - Thanks for the review, Haohui. I'm going to get

[jira] [Commented] (HDFS-5673) Implement logic for modification of ACLs.

[ https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852200#comment-13852200 ] Haohui Mai commented on HDFS-5673: -- Acl: Acl.Builder can initialize the entries field alo

[jira] [Commented] (HDFS-5673) Implement logic for modification of ACLs.

[ https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852021#comment-13852021 ] Chris Nauroth commented on HDFS-5673: - One more note. From looking at this patch alone