[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13933577#comment-13933577
]
Jing Zhao commented on HDFS-6038:
-
Thanks for the review, Todd!
bq. just worried that
[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13931234#comment-13931234
]
Todd Lipcon commented on HDFS-6038:
---
I didn't look at the code in detail, but the design
[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923673#comment-13923673
]
Hadoop QA commented on HDFS-6038:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923725#comment-13923725
]
Jing Zhao commented on HDFS-6038:
-
bq. DataOutputBuffer.writeInt can be simplified as
[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924388#comment-13924388
]
Hadoop QA commented on HDFS-6038:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924561#comment-13924561
]
Hadoop QA commented on HDFS-6038:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924578#comment-13924578
]
Jing Zhao commented on HDFS-6038:
-
[~tlipcon], do you also want to take a look at the
[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924709#comment-13924709
]
Hadoop QA commented on HDFS-6038:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923198#comment-13923198
]
Tsz Wo Nicholas Sze commented on HDFS-6038:
---
- DataOutputBuffer.writeInt can be
[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923244#comment-13923244
]
Tsz Wo Nicholas Sze commented on HDFS-6038:
---
{code}
buffer.setOffset(oldCount);
[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923479#comment-13923479
]
Jing Zhao commented on HDFS-6038:
-
the editsStored binary file needs to be updated again.
[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13921602#comment-13921602
]
Jing Zhao commented on HDFS-6038:
-
After offline discussion with [~szetszwo], the 002 patch
[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13921881#comment-13921881
]
Tsz Wo Nicholas Sze commented on HDFS-6038:
---
- It may be easier to implement
[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13921956#comment-13921956
]
Hadoop QA commented on HDFS-6038:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922115#comment-13922115
]
Hadoop QA commented on HDFS-6038:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918659#comment-13918659
]
Tsz Wo (Nicholas), SZE commented on HDFS-6038:
--
We use uint32 for the
[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918683#comment-13918683
]
Tsz Wo (Nicholas), SZE commented on HDFS-6038:
--
Actually, sint32 used in the
[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918912#comment-13918912
]
Jing Zhao commented on HDFS-6038:
-
One issue with the current patch is that the JN will
[
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918959#comment-13918959
]
Tsz Wo (Nicholas), SZE commented on HDFS-6038:
--
19 matches
Mail list logo
