[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-06-12 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029765#comment-14029765 ] Andrew Wang commented on HDFS-6395: --- +1 from me too, will commit shortly. Only nitty thin

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-06-12 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028920#comment-14028920 ] Yi Liu commented on HDFS-6395: -- Thanks [~cnauroth] for review. Let's see if [~andrew.wang] has

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-06-11 Thread Chris Nauroth (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028005#comment-14028005 ] Chris Nauroth commented on HDFS-6395: - It's looking good, but I'll hold off committing

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-06-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027981#comment-14027981 ] Hadoop QA commented on HDFS-6395: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-06-10 Thread Chris Nauroth (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026678#comment-14026678 ] Chris Nauroth commented on HDFS-6395: - {code} if (xAttr.getNameSpace() == XAttr.Nam

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-06-09 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026032#comment-14026032 ] Andrew Wang commented on HDFS-6395: --- Woops, my bad, I forgot that this patch also fixes t

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-06-09 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025855#comment-14025855 ] Andrew Wang commented on HDFS-6395: --- I should have realized this earlier, considering I w

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-06-06 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019687#comment-14019687 ] Yi Liu commented on HDFS-6395: -- Thanks Andrew. When I look into the detail and discussed with

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-06-05 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019500#comment-14019500 ] Andrew Wang commented on HDFS-6395: --- I chatted with Yi a bit offline with some review fee

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-05-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014844#comment-14014844 ] Hadoop QA commented on HDFS-6395: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-05-31 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014649#comment-14014649 ] Yi Liu commented on HDFS-6395: -- For the boundary test of limits configs, we have existing test

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-05-31 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014642#comment-14014642 ] Yi Liu commented on HDFS-6395: -- Thanks [~andrew.wang]. Right, I will remove the unnecessary i

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-05-30 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014170#comment-14014170 ] Andrew Wang commented on HDFS-6395: --- Makes sense to me, thanks for investigating Yi. We s

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-05-30 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013399#comment-14013399 ] Yi Liu commented on HDFS-6395: -- Hi [~andrew.wang], I think current implementation already cove

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-05-29 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013164#comment-14013164 ] Yi Liu commented on HDFS-6395: -- Thanks Andrew, it makes sense that XAttr enable/disable config

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-05-29 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012941#comment-14012941 ] Andrew Wang commented on HDFS-6395: --- Cool, that's fine with me. I thought a bit more afte

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-05-28 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011932#comment-14011932 ] Yi Liu commented on HDFS-6395: -- Thanks Andrew, actually I have finished part of it last week,

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-05-28 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011619#comment-14011619 ] Andrew Wang commented on HDFS-6395: --- Hey Yi, I'd like to take a hack at this if you're bu

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-05-21 Thread Uma Maheswara Rao G (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004851#comment-14004851 ] Uma Maheswara Rao G commented on HDFS-6395: --- Moved as top level Jira as HDFS-2006

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-05-17 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000719#comment-14000719 ] Yi Liu commented on HDFS-6395: -- Thanks Andrew, I'm handling this. > Assorted improvements to

[jira] [Commented] (HDFS-6395) Assorted improvements to xattr limit checking

2014-05-13 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996989#comment-13996989 ] Andrew Wang commented on HDFS-6395: --- Let's also remove the extra import in FSNamesystem t