[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-10-14 Thread Surendra Singh Lilhore (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950878#comment-16950878 ] Surendra Singh Lilhore commented on HDFS-6524: -- -1 for this change, There is no relation

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-10-14 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950871#comment-16950871 ] Ayush Saxena commented on HDFS-6524: bq. Looks like a good improvement, thanks Lisheng Sun. [~weichiu]

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-10-13 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950369#comment-16950369 ] Wei-Chiu Chuang commented on HDFS-6524: --- Looks like a good improvement, thanks [~leosun08].

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-10-13 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950287#comment-16950287 ] Hadoop QA commented on HDFS-6524: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-10-13 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950286#comment-16950286 ] Lisheng Sun commented on HDFS-6524: --- [~ayushtkn] sorry, I did not understand the meaning of this failure

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-10-13 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950270#comment-16950270 ] Ayush Saxena commented on HDFS-6524: I am sorry, I think I have got little confused, but if I see the

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-10-13 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950239#comment-16950239 ] Lisheng Sun commented on HDFS-6524: --- Thanks [~ayushtkn] for your good suggestions. I updated the patch

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-10-13 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950232#comment-16950232 ] Ayush Saxena commented on HDFS-6524: Thanx [~leosun08] for the patch. Overall Looks Good. Just a minor

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-10-13 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950228#comment-16950228 ] Lisheng Sun commented on HDFS-6524: --- [~surendrasingh] [~weichiu]  [~ayushtkn] Could you help review

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-10-10 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949052#comment-16949052 ] Lisheng Sun commented on HDFS-6524: --- ping [~elgoiri] Should we commit this patch to trunk and all other

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-10-08 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946665#comment-16946665 ] Lisheng Sun commented on HDFS-6524: --- [~elgoiri] Could you help commit this patch to trunk? Thank you a

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-10-04 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944706#comment-16944706 ] Íñigo Goiri commented on HDFS-6524: --- +1 on [^HDFS-6524.006.patch]. > Choosing datanode retries times

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-10-03 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944208#comment-16944208 ] Lisheng Sun commented on HDFS-6524: --- [~elgoiri] In current code 

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-09-28 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940187#comment-16940187 ] Íñigo Goiri commented on HDFS-6524: --- Can you walk me over the tests here? We used to have a replication

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-09-27 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939822#comment-16939822 ] Lisheng Sun commented on HDFS-6524: --- [~elgoiri] Could you have time to continue to reveiew this patch?

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-09-27 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939482#comment-16939482 ] Lisheng Sun commented on HDFS-6524: --- all failed unit tests are not related to this patch. > Choosing

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-09-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938901#comment-16938901 ] Hadoop QA commented on HDFS-6524: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-09-26 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938796#comment-16938796 ] Lisheng Sun commented on HDFS-6524: --- Thanks [~elgoiri] for your good suggestions. Updated UT.

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-09-23 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936079#comment-16936079 ] Íñigo Goiri commented on HDFS-6524: --- [~leosun08], did you add the new path? The current test is changed

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-09-23 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935755#comment-16935755 ] Lisheng Sun commented on HDFS-6524: --- hi [~elgoiri] {quote} Can we have some more coverage for this? We

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-09-17 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931831#comment-16931831 ] Íñigo Goiri commented on HDFS-6524: --- Can we have some more coverage for this? We should cover the old

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-09-17 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931647#comment-16931647 ] Hadoop QA commented on HDFS-6524: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-09-16 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931084#comment-16931084 ] Hadoop QA commented on HDFS-6524: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-09-16 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16930997#comment-16930997 ] Lisheng Sun commented on HDFS-6524: --- hi [~elgoiri] , i agree your option. There are same problems in

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-09-16 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16930723#comment-16930723 ] Íñigo Goiri commented on HDFS-6524: --- Let's avoid the change in TestRollingUpgrade. I think the issue

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-09-15 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929954#comment-16929954 ] Hadoop QA commented on HDFS-6524: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-09-15 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929921#comment-16929921 ] Hadoop QA commented on HDFS-6524: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-09-10 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927103#comment-16927103 ] Íñigo Goiri commented on HDFS-6524: --- Is there any unit test we can add to cover the new case? BTW, that

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-09-10 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926744#comment-16926744 ] Lisheng Sun commented on HDFS-6524: --- hi [~elgoiri], [~ayushtkn] [~xkrogen] Could you have time to help

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-09-02 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920925#comment-16920925 ] Lisheng Sun commented on HDFS-6524: --- hi [~jojochuang] [~ayushtkn]  Could you help take a review for this

[jira] [Commented] (HDFS-6524) Choosing datanode retries times considering with block replica number

2019-08-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915820#comment-16915820 ] Hadoop QA commented on HDFS-6524: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||