[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950878#comment-16950878
]
Surendra Singh Lilhore commented on HDFS-6524:
--
-1 for this change, There is no relation
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950871#comment-16950871
]
Ayush Saxena commented on HDFS-6524:
bq. Looks like a good improvement, thanks Lisheng Sun.
[~weichiu]
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950369#comment-16950369
]
Wei-Chiu Chuang commented on HDFS-6524:
---
Looks like a good improvement, thanks [~leosun08].
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950287#comment-16950287
]
Hadoop QA commented on HDFS-6524:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950286#comment-16950286
]
Lisheng Sun commented on HDFS-6524:
---
[~ayushtkn] sorry, I did not understand the meaning of this failure
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950270#comment-16950270
]
Ayush Saxena commented on HDFS-6524:
I am sorry, I think I have got little confused, but if I see the
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950239#comment-16950239
]
Lisheng Sun commented on HDFS-6524:
---
Thanks [~ayushtkn] for your good suggestions.
I updated the patch
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950232#comment-16950232
]
Ayush Saxena commented on HDFS-6524:
Thanx [~leosun08] for the patch. Overall Looks Good. Just a minor
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950228#comment-16950228
]
Lisheng Sun commented on HDFS-6524:
---
[~surendrasingh] [~weichiu] [~ayushtkn] Could you help review
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949052#comment-16949052
]
Lisheng Sun commented on HDFS-6524:
---
ping [~elgoiri] Should we commit this patch to trunk and all other
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946665#comment-16946665
]
Lisheng Sun commented on HDFS-6524:
---
[~elgoiri] Could you help commit this patch to trunk? Thank you a
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944706#comment-16944706
]
Íñigo Goiri commented on HDFS-6524:
---
+1 on [^HDFS-6524.006.patch].
> Choosing datanode retries times
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944208#comment-16944208
]
Lisheng Sun commented on HDFS-6524:
---
[~elgoiri]
In current code
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940187#comment-16940187
]
Íñigo Goiri commented on HDFS-6524:
---
Can you walk me over the tests here?
We used to have a replication
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939822#comment-16939822
]
Lisheng Sun commented on HDFS-6524:
---
[~elgoiri] Could you have time to continue to reveiew this patch?
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939482#comment-16939482
]
Lisheng Sun commented on HDFS-6524:
---
all failed unit tests are not related to this patch.
> Choosing
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938901#comment-16938901
]
Hadoop QA commented on HDFS-6524:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938796#comment-16938796
]
Lisheng Sun commented on HDFS-6524:
---
Thanks [~elgoiri] for your good suggestions. Updated UT.
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936079#comment-16936079
]
Íñigo Goiri commented on HDFS-6524:
---
[~leosun08], did you add the new path?
The current test is changed
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935755#comment-16935755
]
Lisheng Sun commented on HDFS-6524:
---
hi [~elgoiri]
{quote}
Can we have some more coverage for this?
We
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931831#comment-16931831
]
Íñigo Goiri commented on HDFS-6524:
---
Can we have some more coverage for this?
We should cover the old
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931647#comment-16931647
]
Hadoop QA commented on HDFS-6524:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931084#comment-16931084
]
Hadoop QA commented on HDFS-6524:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16930997#comment-16930997
]
Lisheng Sun commented on HDFS-6524:
---
hi [~elgoiri] , i agree your option.
There are same problems in
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16930723#comment-16930723
]
Íñigo Goiri commented on HDFS-6524:
---
Let's avoid the change in TestRollingUpgrade.
I think the issue
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929954#comment-16929954
]
Hadoop QA commented on HDFS-6524:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929921#comment-16929921
]
Hadoop QA commented on HDFS-6524:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927103#comment-16927103
]
Íñigo Goiri commented on HDFS-6524:
---
Is there any unit test we can add to cover the new case?
BTW, that
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926744#comment-16926744
]
Lisheng Sun commented on HDFS-6524:
---
hi [~elgoiri], [~ayushtkn] [~xkrogen] Could you have time to help
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920925#comment-16920925
]
Lisheng Sun commented on HDFS-6524:
---
hi [~jojochuang] [~ayushtkn] Could you help take a review for this
[
https://issues.apache.org/jira/browse/HDFS-6524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915820#comment-16915820
]
Hadoop QA commented on HDFS-6524:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
31 matches
Mail list logo