[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125240#comment-14125240
]
Andrew Wang commented on HDFS-6951:
---
Overall looks good to me, just some test nits:
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125639#comment-14125639
]
Hadoop QA commented on HDFS-6951:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126034#comment-14126034
]
Hadoop QA commented on HDFS-6951:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126177#comment-14126177
]
Charles Lamb commented on HDFS-6951:
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125230#comment-14125230
]
Andrew Wang commented on HDFS-6951:
---
Blech, it looks like test-patch doesn't like binary
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124443#comment-14124443
]
Hadoop QA commented on HDFS-6951:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14123703#comment-14123703
]
Andrew Wang commented on HDFS-6951:
---
Charles, do you mind rebasing this? It doesn't apply
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124275#comment-14124275
]
Hadoop QA commented on HDFS-6951:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118149#comment-14118149
]
Yi Liu commented on HDFS-6951:
--
Thanks [~clamb], looks good to me, just one comment:
yes,
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118488#comment-14118488
]
Hadoop QA commented on HDFS-6951:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118936#comment-14118936
]
Hadoop QA commented on HDFS-6951:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119015#comment-14119015
]
Charles Lamb commented on HDFS-6951:
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119097#comment-14119097
]
Yi Liu commented on HDFS-6951:
--
Thanks [~clamb], It's OK for me. +1 (non-binding).
Saving
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14115204#comment-14115204
]
Charles Lamb commented on HDFS-6951:
I ran these two tests on my local machine:
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114243#comment-14114243
]
Hadoop QA commented on HDFS-6951:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114722#comment-14114722
]
Hadoop QA commented on HDFS-6951:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114763#comment-14114763
]
Hadoop QA commented on HDFS-6951:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114765#comment-14114765
]
Hadoop QA commented on HDFS-6951:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112681#comment-14112681
]
Hadoop QA commented on HDFS-6951:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112947#comment-14112947
]
Andrew Wang commented on HDFS-6951:
---
Hi Charles, thanks for taking a look at this. Had
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112954#comment-14112954
]
Hadoop QA commented on HDFS-6951:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113193#comment-14113193
]
Yi Liu commented on HDFS-6951:
--
Hi [~clamb], thanks for the fix :)
In original design, we
[
https://issues.apache.org/jira/browse/HDFS-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113313#comment-14113313
]
Hadoop QA commented on HDFS-6951:
-
{color:red}-1 overall{color}. Here are the results of
23 matches
Mail list logo
