[jira] [Commented] (HDFS-7011) Implement basic utilities for libhdfs3

2014-10-01 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155520#comment-14155520 ] Abraham Elmahrek commented on HDFS-7011: +1 Colin! > Implement basic utilities for

[jira] [Commented] (HDFS-7011) Implement basic utilities for libhdfs3

2014-10-01 Thread Zhanwei Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154816#comment-14154816 ] Zhanwei Wang commented on HDFS-7011: patch looks good to me > Implement basic utilitie

[jira] [Commented] (HDFS-7011) Implement basic utilities for libhdfs3

2014-09-30 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154176#comment-14154176 ] Abraham Elmahrek commented on HDFS-7011: Haha you're right. I am blind. LGTM. > Im

[jira] [Commented] (HDFS-7011) Implement basic utilities for libhdfs3

2014-09-30 Thread Zhanwei Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154149#comment-14154149 ] Zhanwei Wang commented on HDFS-7011: Hi Abraham Both FileWrapper and CFileWrapper have

[jira] [Commented] (HDFS-7011) Implement basic utilities for libhdfs3

2014-09-30 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154101#comment-14154101 ] Abraham Elmahrek commented on HDFS-7011: This looks good to me... just one thought:

[jira] [Commented] (HDFS-7011) Implement basic utilities for libhdfs3

2014-09-30 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153773#comment-14153773 ] Colin Patrick McCabe commented on HDFS-7011: bq. Blocking SIGPIPE in backend wo

[jira] [Commented] (HDFS-7011) Implement basic utilities for libhdfs3

2014-09-30 Thread Zhanwei Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153114#comment-14153114 ] Zhanwei Wang commented on HDFS-7011: Blocking SIGPIPE in backend worker thread is not i

[jira] [Commented] (HDFS-7011) Implement basic utilities for libhdfs3

2014-09-29 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152164#comment-14152164 ] Colin Patrick McCabe commented on HDFS-7011: I don't see anything wrong with us

[jira] [Commented] (HDFS-7011) Implement basic utilities for libhdfs3

2014-09-26 Thread Zhanwei Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150420#comment-14150420 ] Zhanwei Wang commented on HDFS-7011: I did not see any confusion about "shared_ptr", it

[jira] [Commented] (HDFS-7011) Implement basic utilities for libhdfs3

2014-09-26 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14149948#comment-14149948 ] Colin Patrick McCabe commented on HDFS-7011: bq. My suggestion is to introduce

[jira] [Commented] (HDFS-7011) Implement basic utilities for libhdfs3

2014-09-26 Thread Zhanwei Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14149122#comment-14149122 ] Zhanwei Wang commented on HDFS-7011: Hi Colin It is ok to use std::tr1::shared_ptr My

[jira] [Commented] (HDFS-7011) Implement basic utilities for libhdfs3

2014-09-26 Thread Zhanwei Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14149098#comment-14149098 ] Zhanwei Wang commented on HDFS-7011: Hi Colin I do not block SIGPIPE in worker thread

[jira] [Commented] (HDFS-7011) Implement basic utilities for libhdfs3

2014-09-24 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146779#comment-14146779 ] Colin Patrick McCabe commented on HDFS-7011: * add ifndef back to DEFAULT_STACK

[jira] [Commented] (HDFS-7011) Implement basic utilities for libhdfs3

2014-09-24 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146548#comment-14146548 ] Colin Patrick McCabe commented on HDFS-7011: bq. As discussed before, libhdfs3

[jira] [Commented] (HDFS-7011) Implement basic utilities for libhdfs3

2014-09-23 Thread Zhanwei Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145826#comment-14145826 ] Zhanwei Wang commented on HDFS-7011: {code} +#ifndef DEFAULT_STACK_PREFIX +#define DEFA

[jira] [Commented] (HDFS-7011) Implement basic utilities for libhdfs3

2014-09-23 Thread Zhanwei Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145805#comment-14145805 ] Zhanwei Wang commented on HDFS-7011: Hi Colin As discussed before, libhdfs3 is not a g

[jira] [Commented] (HDFS-7011) Implement basic utilities for libhdfs3

2014-09-08 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126375#comment-14126375 ] Colin Patrick McCabe commented on HDFS-7011: {code} +namespace Hdfs { +namespac