[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-05-05 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529532#comment-14529532 ] Zhe Zhang commented on HDFS-7348: - Thanks Yi for the update! The patch LGTM. The only conce

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-05-04 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527730#comment-14527730 ] Yi Liu commented on HDFS-7348: -- Thanks Zhe for the review, I will update the patch according t

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-05-04 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527427#comment-14527427 ] Zhe Zhang commented on HDFS-7348: - Thanks Yi for the updated patch! It basically LGTM; plea

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-05-01 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524425#comment-14524425 ] Yi Liu commented on HDFS-7348: -- Thanks Zhe for the review and good comments! I am updating the

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-04-30 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522760#comment-14522760 ] Zhe Zhang commented on HDFS-7348: - Please find my full review below. The overall patch look

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-04-30 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521517#comment-14521517 ] Kai Zheng commented on HDFS-7348: - Thanks [~hitliuyi], [~zhz] and [~libo-intel] for the gre

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-04-30 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521026#comment-14521026 ] Yi Liu commented on HDFS-7348: -- Thanks Zhe and Bo for further discussion. I will rebase the pa

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-04-29 Thread Li Bo (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520951#comment-14520951 ] Li Bo commented on HDFS-7348: - bq. We can do local writing and local reading logics as follow-o

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-04-29 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520910#comment-14520910 ] Zhe Zhang commented on HDFS-7348: - bq. Currently the default cell size is 256KB, it's not a

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-04-29 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520899#comment-14520899 ] Zhe Zhang commented on HDFS-7348: - Thanks Yi for the explanation. bq. Current implementat

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-04-29 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520686#comment-14520686 ] Yi Liu commented on HDFS-7348: -- Thanks Bo and Zhe, for the discussion. {quote} On the write p

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-04-29 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520589#comment-14520589 ] Zhe Zhang commented on HDFS-7348: - Thanks for the discussion Yi and Bo. On the write path:

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-04-29 Thread Li Bo (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518918#comment-14518918 ] Li Bo commented on HDFS-7348: - Thanks Yi for the great work! I think decreasing network I/O is

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-04-29 Thread Li Bo (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518935#comment-14518935 ] Li Bo commented on HDFS-7348: - We can give two working modes to the recovery work, Fast, or Slo

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-04-28 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518630#comment-14518630 ] Yi Liu commented on HDFS-7348: -- Thanks [~zhz] for the review! The comments are helpful. {quot

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-04-28 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518362#comment-14518362 ] Zhe Zhang commented on HDFS-7348: - Please find detailed comments below: Logics: # Since re

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-04-28 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518240#comment-14518240 ] Zhe Zhang commented on HDFS-7348: - A quick comment first: A the DN level I don't think we

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-04-28 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518215#comment-14518215 ] Zhe Zhang commented on HDFS-7348: - Great work Yi! I'm reviewing HADOOP-11847; hope we can g

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-04-28 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518145#comment-14518145 ] Zhe Zhang commented on HDFS-7348: - We might be able to share some decoding code. > Erasure

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-04-28 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517087#comment-14517087 ] Yi Liu commented on HDFS-7348: -- {{testFileBlocksRecovery}} is to test the file blocks recovery

[jira] [Commented] (HDFS-7348) Erasure Coding: striped block recovery

2015-04-28 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517080#comment-14517080 ] Yi Liu commented on HDFS-7348: -- {noformat} DataRecoveryAndTransfer recover one or more missed