[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-07 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310900#comment-14310900 ] Konstantin Shvachko commented on HDFS-7738: --- I agree your method of partitioning

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309818#comment-14309818 ] Tsz Wo Nicholas Sze commented on HDFS-7738: --- In general I don't like random

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309819#comment-14309819 ] Tsz Wo Nicholas Sze commented on HDFS-7738: --- TestHAAppend fails waiting on

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-06 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309829#comment-14309829 ] Tsz Wo Nicholas Sze commented on HDFS-7738: --- If the desire to have these is

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-06 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309727#comment-14309727 ] Konstantin Shvachko commented on HDFS-7738: --- it is better to have some random

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-06 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309734#comment-14309734 ] Konstantin Shvachko commented on HDFS-7738: --- TestHAAppend fails waiting on

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310024#comment-14310024 ] Hadoop QA commented on HDFS-7738: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310562#comment-14310562 ] Hadoop QA commented on HDFS-7738: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-06 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310394#comment-14310394 ] Konstantin Shvachko commented on HDFS-7738: --- # Since you kept TestHAAppend in the

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310425#comment-14310425 ] Hadoop QA commented on HDFS-7738: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-05 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306822#comment-14306822 ] Konstantin Shvachko commented on HDFS-7738: --- Hey Nicholas, agreed more test cases

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-05 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308779#comment-14308779 ] Konstantin Shvachko commented on HDFS-7738: --- # {{RecoverLeaseOp}} should be

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308616#comment-14308616 ] Hadoop QA commented on HDFS-7738: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-05 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306851#comment-14306851 ] Konstantin Shvachko commented on HDFS-7738: --- For truncate tests with HA it

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-05 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308317#comment-14308317 ] Tsz Wo Nicholas Sze commented on HDFS-7738: --- h7738_20150205.patch: - adds

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308535#comment-14308535 ] Hadoop QA commented on HDFS-7738: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-04 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306563#comment-14306563 ] Tsz Wo Nicholas Sze commented on HDFS-7738: --- Thanks for the quick review. Since

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306717#comment-14306717 ] Hadoop QA commented on HDFS-7738: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-04 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306558#comment-14306558 ] Yi Liu commented on HDFS-7738: -- I notice the patch distinguishes recover lease exception

[jira] [Commented] (HDFS-7738) Add more negative tests for truncate

2015-02-04 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306573#comment-14306573 ] Yi Liu commented on HDFS-7738: -- {quote} I rather keep this patch simple. Sounds good? {quote}