[jira] [Commented] (HDFS-7964) Add support for async edit logging

2017-10-05 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193806#comment-16193806 ] Andrew Wang commented on HDFS-7964: --- Thanks Kihwal, filed HDFS-12603 to make this happen.

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2017-10-05 Thread Kihwal Lee (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193784#comment-16193784 ] Kihwal Lee commented on HDFS-7964: -- bq. Should we consider turning this on by default in n

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2017-10-05 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193773#comment-16193773 ] Andrew Wang commented on HDFS-7964: --- Should we consider turning this on by default in new

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2017-09-29 Thread Kihwal Lee (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185888#comment-16185888 ] Kihwal Lee commented on HDFS-7964: -- bq. How many handler threads are used for the 285k QPS

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2017-09-28 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185037#comment-16185037 ] Zhe Zhang commented on HDFS-7964: - Very impressive numbers [~daryn]. How many handler threa

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2017-09-28 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184659#comment-16184659 ] Daryn Sharp commented on HDFS-7964: --- Wow that looks super broken. I hope you don't get d

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2017-07-21 Thread photogamerun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096107#comment-16096107 ] photogamerun commented on HDFS-7964: I found if editPendingQ in FSEditLogAsync.java bl

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2017-06-05 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037810#comment-16037810 ] Zhe Zhang commented on HDFS-7964: - I took some time trying to fix HDFS-11737 unit test fail

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2017-05-01 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991842#comment-15991842 ] Zhe Zhang commented on HDFS-7964: - Sorry for keeping this JIRA open for long time. I create

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2017-01-06 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805898#comment-15805898 ] Junping Du commented on HDFS-7964: -- move to 2.9 as 2.8 RC is in progress. > Add support f

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2016-11-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628513#comment-15628513 ] Hadoop QA commented on HDFS-7964: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2016-11-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15627922#comment-15627922 ] Hadoop QA commented on HDFS-7964: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2016-11-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15627893#comment-15627893 ] Hadoop QA commented on HDFS-7964: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2016-11-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15627888#comment-15627888 ] Hadoop QA commented on HDFS-7964: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2016-10-31 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623774#comment-15623774 ] Zhe Zhang commented on HDFS-7964: - The findbug warning is addressed by HDFS-10485. Reported

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2016-10-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623710#comment-15623710 ] Hadoop QA commented on HDFS-7964: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2016-02-29 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172922#comment-15172922 ] Hudson commented on HDFS-7964: -- FAILURE: Integrated in Hadoop-trunk-Commit #9395 (See [https:

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2016-02-29 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172637#comment-15172637 ] Daryn Sharp commented on HDFS-7964: --- Feel funny saying +1 to my own patch. Only differen

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2016-02-17 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150970#comment-15150970 ] Jing Zhao commented on HDFS-7964: - just merge conflicts. you can compare the diff between t

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2016-02-17 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150918#comment-15150918 ] Daryn Sharp commented on HDFS-7964: --- Thanks for the rebase. I'm currently really busy bu

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2016-02-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149395#comment-15149395 ] Hadoop QA commented on HDFS-7964: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2016-02-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145715#comment-15145715 ] Hadoop QA commented on HDFS-7964: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2016-02-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145511#comment-15145511 ] Hadoop QA commented on HDFS-7964: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2016-02-12 Thread Dave Latham (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145469#comment-15145469 ] Dave Latham commented on HDFS-7964: --- Would love to see this get committed. > Add support

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-12-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061297#comment-15061297 ] Jing Zhao commented on HDFS-7964: - The patch looks good to me. One nit is that two places i

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-12-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060976#comment-15060976 ] Jing Zhao commented on HDFS-7964: - Sorry for the late response, Daryn. The current patch lo

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-12-16 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060950#comment-15060950 ] Daryn Sharp commented on HDFS-7964: --- I'm trying to whittle down my backlog of internal fe

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-12-15 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058219#comment-15058219 ] Daryn Sharp commented on HDFS-7964: --- Comments? > Add support for async edit logging > --

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-10-29 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981323#comment-14981323 ] Daryn Sharp commented on HDFS-7964: --- I think special casing a few ops is fragile even if

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-10-21 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14967625#comment-14967625 ] Jing Zhao commented on HDFS-7964: - Thanks for updating the patch, Daryn. bq. It's ensuring

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-10-20 Thread Walter Su (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966300#comment-14966300 ] Walter Su commented on HDFS-7964: - {code} if (call.connection.responseQueue.size() == 1) {

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-10-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965419#comment-14965419 ] Hadoop QA commented on HDFS-7964: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-10-20 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965106#comment-14965106 ] Daryn Sharp commented on HDFS-7964: --- # It's ensuring correctness by preventing a deadlock

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-10-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14962829#comment-14962829 ] Hadoop QA commented on HDFS-7964: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-10-18 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14962767#comment-14962767 ] Yi Liu commented on HDFS-7964: -- 1. That's right. 2. You can keep it. > Add support for async

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-10-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14961593#comment-14961593 ] Jing Zhao commented on HDFS-7964: - Thanks for rebasing the patch, Daryn. The patch looks go

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-10-16 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960721#comment-14960721 ] Daryn Sharp commented on HDFS-7964: --- # The thread is the only one calling the real logEdi

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-10-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960144#comment-14960144 ] Hadoop QA commented on HDFS-7964: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-10-15 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960114#comment-14960114 ] Yi Liu commented on HDFS-7964: -- Thanks [~daryn] for the work. Further comments: *1.* In FSEd

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-08-18 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702369#comment-14702369 ] Yi Liu commented on HDFS-7964: -- {quote} All 2.6 clusters have been running with the feature en

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-08-18 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701823#comment-14701823 ] Daryn Sharp commented on HDFS-7964: --- [~hitliuyi], I'm sure I'll need to rebase. The batc

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-03-30 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386638#comment-14386638 ] Yi Liu commented on HDFS-7964: -- [~daryn], this is a cool and important improvement. Besides th

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-03-20 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372334#comment-14372334 ] Daryn Sharp commented on HDFS-7964: --- As background, the problem was tackled after recurri

[jira] [Commented] (HDFS-7964) Add support for async edit logging

2015-03-20 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372226#comment-14372226 ] Daryn Sharp commented on HDFS-7964: --- Patch won't compile w/o HADOOP-10300 so not submitti