[
https://issues.apache.org/jira/browse/HDFS-8775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705578#comment-14705578
]
Bob Hansen commented on HDFS-8775:
--
Given those responses to the review, +1
SASL support
[
https://issues.apache.org/jira/browse/HDFS-8775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705253#comment-14705253
]
James Clampffer commented on HDFS-8775:
---
+1
SASL support for data transfer protocol
[
https://issues.apache.org/jira/browse/HDFS-8775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694015#comment-14694015
]
Haohui Mai commented on HDFS-8775:
--
Thanks for the reviews.
The code basically blindly
[
https://issues.apache.org/jira/browse/HDFS-8775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662123#comment-14662123
]
Bob Hansen commented on HDFS-8775:
--
The lack of comments makes it very hard to verify that
[
https://issues.apache.org/jira/browse/HDFS-8775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662141#comment-14662141
]
Bob Hansen commented on HDFS-8775:
--
In the tests, we need some negative tests:
* How does
[
https://issues.apache.org/jira/browse/HDFS-8775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659972#comment-14659972
]
James Clampffer commented on HDFS-8775:
---
I should have read the style guide better.
[
https://issues.apache.org/jira/browse/HDFS-8775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14658938#comment-14658938
]
Haohui Mai commented on HDFS-8775:
--
bq. I think it would make things more maintainable to
[
https://issues.apache.org/jira/browse/HDFS-8775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14653801#comment-14653801
]
James Clampffer commented on HDFS-8775:
---
I'm still learning more about the actual
