[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14703563#comment-14703563 ] Hadoop QA commented on HDFS-8828: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14703591#comment-14703591 ] Yongjun Zhang commented on HDFS-8828: - Hi [~jingzhao], Thanks a lot for your review

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702551#comment-14702551 ] Hadoop QA commented on HDFS-8828: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701760#comment-14701760 ] Jing Zhao commented on HDFS-8828: - Thanks for updating the patch, Yufei! Some further

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701789#comment-14701789 ] Hadoop QA commented on HDFS-8828: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702333#comment-14702333 ] Hadoop QA commented on HDFS-8828: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702194#comment-14702194 ] Yufei Gu commented on HDFS-8828: Hi [~jingzhao], Thank you very much for great comments.

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701574#comment-14701574 ] Yufei Gu commented on HDFS-8828: Hi [~jingzhao], Thank you very much for review and nice

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699664#comment-14699664 ] Yongjun Zhang commented on HDFS-8828: - Hi [~jingzhao], Thanks for the review and good

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699950#comment-14699950 ] Jing Zhao commented on HDFS-8828: - Yes, we can try to use DistCpSync or a new class to

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699781#comment-14699781 ] Yufei Gu commented on HDFS-8828: Hi [~jingzhao], Thank you very much for the review and

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698784#comment-14698784 ] Yongjun Zhang commented on HDFS-8828: - Thanks [~yufeigu], +1 on rev 007. Utilize

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698985#comment-14698985 ] Jing Zhao commented on HDFS-8828: - Thanks again for working on this, Yufei. The patch looks

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694855#comment-14694855 ] Yongjun Zhang commented on HDFS-8828: - Hi [~yufeigu], Thanks for the new rev 006

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695685#comment-14695685 ] Yongjun Zhang commented on HDFS-8828: - Hello [~yufeigu], I expect every new

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696023#comment-14696023 ] Jing Zhao commented on HDFS-8828: - Sure. I will review the patch. Thanks for the work,

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696224#comment-14696224 ] Yongjun Zhang commented on HDFS-8828: - Thank you [~yufeigu] and [~jingzhao]! Utilize

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696167#comment-14696167 ] Yufei Gu commented on HDFS-8828: Thank you, [~jingzhao]. Glad to have you review the code.

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696164#comment-14696164 ] Yufei Gu commented on HDFS-8828: Hi [~yzhangal], Thanks very much for code review. I've

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696000#comment-14696000 ] Yongjun Zhang commented on HDFS-8828: - Hi [~yufeigu], Thanks for answering my question

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696162#comment-14696162 ] Yufei Gu commented on HDFS-8828: No. Just one CREATE item in snapshot diff report in this

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696383#comment-14696383 ] Hadoop QA commented on HDFS-8828: - \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695467#comment-14695467 ] Yufei Gu commented on HDFS-8828: Hi [~yzhangal], Thank you for detailed review. For 3, we

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14692442#comment-14692442 ] Hadoop QA commented on HDFS-8828: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662836#comment-14662836 ] Hadoop QA commented on HDFS-8828: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662875#comment-14662875 ] Yongjun Zhang commented on HDFS-8828: - HI [~yufeigu], Thanks for addressing my above

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14663044#comment-14663044 ] Yongjun Zhang commented on HDFS-8828: - Looked at the checkstyle now, and realized that

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14663047#comment-14663047 ] Yongjun Zhang commented on HDFS-8828: - {code} return childPath.length()

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14663078#comment-14663078 ] Yufei Gu commented on HDFS-8828: Hi [~yzhangal], Thank you very much for detailed code

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14663093#comment-14663093 ] Hadoop QA commented on HDFS-8828: - \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661976#comment-14661976 ] Yongjun Zhang commented on HDFS-8828: - Thanks [~yufeigu] for the new rev and

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652789#comment-14652789 ] Jing Zhao commented on HDFS-8828: - Thanks for the explanation, Yufei! Yes, you're right

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652736#comment-14652736 ] Yufei Gu commented on HDFS-8828: Hi Jing Zhao, Thank you for reviewing the code. We

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652728#comment-14652728 ] Hadoop QA commented on HDFS-8828: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652559#comment-14652559 ] Jing Zhao commented on HDFS-8828: - Thanks for working on this, Yufei! One quick comment is

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652525#comment-14652525 ] Yufei Gu commented on HDFS-8828: Hi Yongjun, Thank you very much for detailed code review

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14650627#comment-14650627 ] Yongjun Zhang commented on HDFS-8828: - Hi [~yufeigu], Thanks for reporting the issue

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14650195#comment-14650195 ] Hadoop QA commented on HDFS-8828: - \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HDFS-8828) Utilize Snapshot diff report to build copy list in distcp

[ https://issues.apache.org/jira/browse/HDFS-8828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14650080#comment-14650080 ] Hadoop QA commented on HDFS-8828: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||