[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2018-03-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410416#comment-16410416 ] Hudson commented on HDFS-9118: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13869 (See

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-03-23 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209270#comment-15209270 ] James Clampffer commented on HDFS-9118: --- Thanks for the reviews Bob. I'll open a jira for tying

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-03-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209231#comment-15209231 ] Hadoop QA commented on HDFS-9118: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-03-23 Thread Bob Hansen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209202#comment-15209202 ] Bob Hansen commented on HDFS-9118: -- +1. Looks good. Can you file a new Jira and reference it here to

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-03-23 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208701#comment-15208701 ] James Clampffer commented on HDFS-9118: --- Didn't see you had more comments above my last message,

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-03-23 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208612#comment-15208612 ] James Clampffer commented on HDFS-9118: --- bq. Before we commit it, do you think we should add a _FILE_

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-03-23 Thread Bob Hansen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208411#comment-15208411 ] Bob Hansen commented on HDFS-9118: -- Before we commit it, do you think we should add a __FILE__ and

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-03-22 Thread Bob Hansen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206527#comment-15206527 ] Bob Hansen commented on HDFS-9118: -- I like the look of that patch, [~James Clampffer]. A few more

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-03-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206193#comment-15206193 ] Hadoop QA commented on HDFS-9118: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-03-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205581#comment-15205581 ] Hadoop QA commented on HDFS-9118: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-03-19 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198193#comment-15198193 ] James Clampffer commented on HDFS-9118: --- bq. The downside of this approach is that all of the

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-03-19 Thread Bob Hansen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198029#comment-15198029 ] Bob Hansen commented on HDFS-9118: -- James - thanks for carrying that forward and festooning our code with

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-03-10 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189643#comment-15189643 ] James Clampffer commented on HDFS-9118: --- Disregard the stuff about template instantiations not

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-03-10 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189499#comment-15189499 ] James Clampffer commented on HDFS-9118: --- bq. Great. If we can, let's implement the plugins for the

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-03-09 Thread Bob Hansen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187915#comment-15187915 ] Bob Hansen commented on HDFS-9118: -- Great. If we can, let's implement the plugins for the C-API glue

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-03-09 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187815#comment-15187815 ] James Clampffer commented on HDFS-9118: --- Thanks for the feedback [~bobthansen], I hadn't thought

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-03-09 Thread Bob Hansen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187470#comment-15187470 ] Bob Hansen commented on HDFS-9118: -- [~James Clampffer] - thanks for moving this forward. I would like to

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-03-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186291#comment-15186291 ] Hadoop QA commented on HDFS-9118: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-03-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181341#comment-15181341 ] Hadoop QA commented on HDFS-9118: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-01-25 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115421#comment-15115421 ] James Clampffer commented on HDFS-9118: --- I'm going to take a shot at this. Things I'm planning on

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-01-25 Thread Bob Hansen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115434#comment-15115434 ] Bob Hansen commented on HDFS-9118: -- Grabbing the stack address is a fairly expensive operation. I would

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2016-01-25 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116065#comment-15116065 ] James Clampffer commented on HDFS-9118: --- Shouldn't getting the stack address of a local variable boil

[jira] [Commented] (HDFS-9118) Add logging system for libdhfs++

2015-09-21 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14901630#comment-14901630 ] Haohui Mai commented on HDFS-9118: -- The interfaces of logging class are quite closed to the one used in