[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447453#comment-15447453
]
Andrew Wang commented on HDFS-9226:
---
Note for future git log greppers, JIRA ID typo'd as HDFS-9926.
>
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289441#comment-15289441
]
Arpit Agarwal commented on HDFS-9226:
-
Also thanks to [~vinayrpet] and [~iwasakims] for the earlier
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289251#comment-15289251
]
Josh Elser commented on HDFS-9226:
--
bq. Test failures were not caused by the patch (verified all tests
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289233#comment-15289233
]
Arpit Agarwal commented on HDFS-9226:
-
Test failures were not caused by the patch. The checkstyle
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289179#comment-15289179
]
Josh Elser commented on HDFS-9226:
--
Hrm, let me take a look at these unit test failures and checkstyle. I
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288568#comment-15288568
]
Hadoop QA commented on HDFS-9226:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288455#comment-15288455
]
Arpit Agarwal commented on HDFS-9226:
-
+1 pending Jenkins. Thank you [~elserj]!
> MiniDFSCluster leaks
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288134#comment-15288134
]
Josh Elser commented on HDFS-9226:
--
bq. so here's a rebase on top of master.
Oh my. {{master}} is not
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967672#comment-14967672
]
Arpit Agarwal commented on HDFS-9226:
-
Thanks [~iwasakims], we should eliminate the new dependency i.e.
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966407#comment-14966407
]
Masatake Iwasaki commented on HDFS-9226:
{code}
277 Mockito.doAnswer(new Answer() {
278
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965495#comment-14965495
]
Arpit Agarwal commented on HDFS-9226:
-
Hi [~elserj], thanks for taking this up. I must confess I don't
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965545#comment-14965545
]
Josh Elser commented on HDFS-9226:
--
bq. I must confess I don't understand how HDFS-8953 introduced this.
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14962801#comment-14962801
]
Josh Elser commented on HDFS-9226:
--
Anything else that needs to be done here? This at least fixed the
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957042#comment-14957042
]
Josh Elser commented on HDFS-9226:
--
bq. I agree with this. Adding mockito as dependency would be better.
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957503#comment-14957503
]
Josh Elser commented on HDFS-9226:
--
Well, I thought this would be simple, but it seems like I might be
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957733#comment-14957733
]
Hadoop QA commented on HDFS-9226:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956726#comment-14956726
]
Vinayakumar B commented on HDFS-9226:
-
bq. hadoop-minicluster is intended to be used in tests. Adding
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956699#comment-14956699
]
Masatake Iwasaki commented on HDFS-9226:
Thanks for the update, [~elserj]. Though the patch looks
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956712#comment-14956712
]
Masatake Iwasaki commented on HDFS-9226:
bq. adding in Mockito is also a scary consideration as
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14958353#comment-14958353
]
Masatake Iwasaki commented on HDFS-9226:
bq. Every other changes in hdfs tests need not verify for
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952817#comment-14952817
]
Hadoop QA commented on HDFS-9226:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953305#comment-14953305
]
Masatake Iwasaki commented on HDFS-9226:
bq. There is no guard to keep someone from adding code
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953290#comment-14953290
]
Masatake Iwasaki commented on HDFS-9226:
Hmm... Though [test artifacts are intended to be
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953601#comment-14953601
]
Josh Elser commented on HDFS-9226:
--
bq. The class name InternalDataNodeTestUtils is not clear because test
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14954230#comment-14954230
]
Hadoop QA commented on HDFS-9226:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952424#comment-14952424
]
Josh Elser commented on HDFS-9226:
--
FYI, [~kanaka], [~vinayrpet], [~arpitagarwal], [~ste...@apache.org]
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952500#comment-14952500
]
Hadoop QA commented on HDFS-9226:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952498#comment-14952498
]
Josh Elser commented on HDFS-9226:
--
001 takes the route of just moving the test utilities that rely on
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952642#comment-14952642
]
Josh Elser commented on HDFS-9226:
--
Thanks for taking a look, [~iwasakims].
bq. Mockito has been used for
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952619#comment-14952619
]
Hadoop QA commented on HDFS-9226:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952632#comment-14952632
]
Masatake Iwasaki commented on HDFS-9226:
Mockito has been used for a long time by
31 matches
Mail list logo
