[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1696#comment-1696
]
Hudson commented on HDFS-9342:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11695 (See
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997825#comment-15997825
]
Hadoop QA commented on HDFS-9342:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997816#comment-15997816
]
SammiChen commented on HDFS-9342:
-
Woops! Forgot address your comments. Will upload a new patch later.
>
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997759#comment-15997759
]
Andrew Wang commented on HDFS-9342:
---
Hi Sammi, I think my minor comments from previous review have not
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997700#comment-15997700
]
SammiChen commented on HDFS-9342:
-
Hi [~andrew.wang], I rebased v4 patch against the latest trunk to get v5
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997206#comment-15997206
]
Andrew Wang commented on HDFS-9342:
---
Thanks for reviewing Zhe!
Ping [~Sammi], think we can get a quick
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987835#comment-15987835
]
Zhe Zhang commented on HDFS-9342:
-
Sorry for the late response. Yes the main logic LGTM as well. I spent
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965164#comment-15965164
]
Andrew Wang commented on HDFS-9342:
---
LGTM, thanks Sammi for refining, only some minors:
* Please add a
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960624#comment-15960624
]
Hadoop QA commented on HDFS-9342:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817063#comment-15817063
]
Hadoop QA commented on HDFS-9342:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816813#comment-15816813
]
Andrew Wang commented on HDFS-9342:
---
This one looks important for correctness. Could one of the watchers
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072472#comment-15072472
]
Walter Su commented on HDFS-9342:
-
{code}
for (int i = 0; i < numAllBlocks; i++) {
final
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072496#comment-15072496
]
Hadoop QA commented on HDFS-9342:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049649#comment-15049649
]
Zhe Zhang commented on HDFS-9342:
-
Thanks Walter (and sorry about the late review). The algorithm LGTM. A
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012533#comment-15012533
]
Walter Su commented on HDFS-9342:
-
I just realize I didn't consider padding zero of last stripe. Will
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012793#comment-15012793
]
Hadoop QA commented on HDFS-9342:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012445#comment-15012445
]
Zhe Zhang commented on HDFS-9342:
-
I agree, we can add the test as part of HDFS-7661.
I will make another
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012717#comment-15012717
]
Walter Su commented on HDFS-9342:
-
When there is DN failure, and last stripe is partial, there is no way to
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010419#comment-15010419
]
Walter Su commented on HDFS-9342:
-
Protocol updatePipeline(..) will update block length, but only the acked
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007561#comment-15007561
]
Zhe Zhang commented on HDFS-9342:
-
Thanks Walter. The fix looks OK for closing file and allocation new
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007871#comment-15007871
]
Walter Su commented on HDFS-9342:
-
Sorry I didn't get it. You mean I should add a test for the change in
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008191#comment-15008191
]
Zhe Zhang commented on HDFS-9342:
-
Sorry I missed the change in {{updatePipeline}}. So we get the acked
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996141#comment-14996141
]
Hadoop QA commented on HDFS-9342:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982192#comment-14982192
]
Walter Su commented on HDFS-9342:
-
Both {{updatePipeline}} and {{commitBlock}} will set the visible length
24 matches
Mail list logo
