[jira] [Commented] (HDFS-9419) Add Optional class to libhdfs++

2015-11-12 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003086#comment-15003086 ] Haohui Mai commented on HDFS-9419: -- Actually since the change of whitespace is trivial I'l

[jira] [Commented] (HDFS-9419) Add Optional class to libhdfs++

2015-11-12 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003074#comment-15003074 ] Haohui Mai commented on HDFS-9419: -- +1 after fixing the whitespaces and tabs. > Add Optio

[jira] [Commented] (HDFS-9419) Add Optional class to libhdfs++

2015-11-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003071#comment-15003071 ] Hadoop QA commented on HDFS-9419: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-9419) Add Optional class to libhdfs++

2015-11-12 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002546#comment-15002546 ] Haohui Mai commented on HDFS-9419: -- s/TR2/tr2 so that it looks consistent under both Windo

[jira] [Commented] (HDFS-9419) Add Optional class to libhdfs++

2015-11-12 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002298#comment-15002298 ] James Clampffer commented on HDFS-9419: --- Not much to it. Looks good to me. +1 > Ad

[jira] [Commented] (HDFS-9419) Add Optional class to libhdfs++

2015-11-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15001606#comment-15001606 ] Hadoop QA commented on HDFS-9419: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||