[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15481164#comment-15481164
]
Xiao Chen commented on HDFS-9781:
-
I've backported this to branch-2.8 too, after the other fixes Arpit did.
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478821#comment-15478821
]
Hadoop QA commented on HDFS-9781:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478703#comment-15478703
]
Hadoop QA commented on HDFS-9781:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478373#comment-15478373
]
Xiao Chen commented on HDFS-9781:
-
+1 pending jenkins. Thanks, Manoj!
> FsDatasetImpl#getBlockReports can
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478295#comment-15478295
]
Xiao Chen commented on HDFS-9781:
-
{code}
// lets return without volRemoveCompletedLatch
// count down, so
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477889#comment-15477889
]
Hudson commented on HDFS-9781:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10419 (See
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477833#comment-15477833
]
Manoj Govindassamy commented on HDFS-9781:
--
Thanks [~xiaochen] for the review and commit help.
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477827#comment-15477827
]
Xiao Chen commented on HDFS-9781:
-
Committed the addendum patch (#4) to trunk.
>
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477713#comment-15477713
]
Xiao Chen commented on HDFS-9781:
-
Talked with [~manojg] offline. The test failure is because we didn't
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472757#comment-15472757
]
Hadoop QA commented on HDFS-9781:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472614#comment-15472614
]
Hadoop QA commented on HDFS-9781:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472295#comment-15472295
]
Manoj Govindassamy commented on HDFS-9781:
--
[~arpitagarwal],
Given that
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471840#comment-15471840
]
Arpit Agarwal commented on HDFS-9781:
-
Hi [~manojg], there's no one explicitly signaling the condition
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468710#comment-15468710
]
Manoj Govindassamy commented on HDFS-9781:
--
[~arpitagarwal], I agree. The patch you shared solves
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468599#comment-15468599
]
Arpit Agarwal commented on HDFS-9781:
-
Hi [~manojg], the wait issue in removeVolumes (HDFS-10830)
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468073#comment-15468073
]
Manoj Govindassamy commented on HDFS-9781:
--
[~arpitagarwal], Thanks for looking at test failures.
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15466285#comment-15466285
]
Arpit Agarwal commented on HDFS-9781:
-
bq. As Xiao Chen mentioned, the updated test case
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15460302#comment-15460302
]
Xiao Chen commented on HDFS-9781:
-
Findbugs warning is due to HDFS-10745, I left a comment on that jira.
>
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15460177#comment-15460177
]
Hadoop QA commented on HDFS-9781:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15460174#comment-15460174
]
Manoj Govindassamy commented on HDFS-9781:
--
As [~xiaochen] mentioned, the updated test case
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15460168#comment-15460168
]
Hadoop QA commented on HDFS-9781:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459992#comment-15459992
]
Xiao Chen commented on HDFS-9781:
-
Discussed this offline with Manoj.
This jira fixes the NPE, and also
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459931#comment-15459931
]
Xiao Chen commented on HDFS-9781:
-
Branch-2 patch looks good too, committing shortly.
>
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459916#comment-15459916
]
Hadoop QA commented on HDFS-9781:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459831#comment-15459831
]
Hudson commented on HDFS-9781:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10394 (See
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459773#comment-15459773
]
Xiao Chen commented on HDFS-9781:
-
I have committed this to trunk.
There are some minor conflicts
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459700#comment-15459700
]
Xiao Chen commented on HDFS-9781:
-
[~jojochuang] ping'ed me offline saying this looks fine to me too.
I'll
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459653#comment-15459653
]
Xiao Chen commented on HDFS-9781:
-
Patch 3 LGTM, +1. Will wait to see if any comments from others.
>
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459622#comment-15459622
]
Hadoop QA commented on HDFS-9781:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458891#comment-15458891
]
Manoj Govindassamy commented on HDFS-9781:
--
Thanks for the review [~jojochuang].
* sure, will add
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458587#comment-15458587
]
Wei-Chiu Chuang commented on HDFS-9781:
---
Hi [~manojg] and thanks everyone here for comments. When I
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457643#comment-15457643
]
Manoj Govindassamy commented on HDFS-9781:
--
[~xiaochen], Thanks for the review. Sure, will prune
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457568#comment-15457568
]
Xiao Chen commented on HDFS-9781:
-
Sorry for my epic slow response on this one And thanks all for
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457208#comment-15457208
]
Manoj Govindassamy commented on HDFS-9781:
--
TestFileChecksum unit test failure is not related to
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457107#comment-15457107
]
Hadoop QA commented on HDFS-9781:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456904#comment-15456904
]
Manoj Govindassamy commented on HDFS-9781:
--
Filed HDFS-10830 to track IllegalMonitorStateException
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15454036#comment-15454036
]
Manoj Govindassamy commented on HDFS-9781:
--
Ref:
{code:title=FsDatasetImpl.java|borderStyle=solid}
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15453821#comment-15453821
]
Manoj Govindassamy commented on HDFS-9781:
--
Ref: {noformat}
@Override
public
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406257#comment-15406257
]
Daryn Sharp commented on HDFS-9781:
---
Yes, in {{FsDatasetImpl#getBlockReports()}}, this chunk:
{code}
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169947#comment-15169947
]
Lei (Eddy) Xu commented on HDFS-9781:
-
Hey, [~xiaochen] and [~jojochuang] Thanks a lot for working
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145439#comment-15145439
]
Xiao Chen commented on HDFS-9781:
-
Chatted with [~jojochuang] offline, the test timeouts because of the NPE
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145381#comment-15145381
]
Wei-Chiu Chuang commented on HDFS-9781:
---
[~xiaochen] Thanks for taking time to reproduce the issue.
[
https://issues.apache.org/jira/browse/HDFS-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139140#comment-15139140
]
Wei-Chiu Chuang commented on HDFS-9781:
---
This is related to HDFS-9701, which created
43 matches
Mail list logo
