Mingliang Liu created HDFS-9304:
-----------------------------------

             Summary: Add HdfsClientConfigKeys class to 
TestHdfsConfigFields#configurationClasses
                 Key: HDFS-9304
                 URL: https://issues.apache.org/jira/browse/HDFS-9304
             Project: Hadoop HDFS
          Issue Type: Sub-task
            Reporter: Mingliang Liu
            Assignee: Mingliang Liu


*tl;dr* Since {{HdfsClientConfigKeys}} holds client side config keys, we need 
to add this class to {{TestHdfsConfigFields#configurationClasses}}.

Now the {{TestHdfsConfigFields}} unit test passes because {{DFSConfigKeys}} 
still contains all the client side config keys, though marked @deprecated. As 
we add new client config keys (e.g. [HDFS-9259]), the unit test will fail with 
the following error:
{quote}
hdfs-default.xml has 1 properties missing in  class 
org.apache.hadoop.hdfs.DFSConfigKeys
{quote}

If the logic is to make the {{DFSConfigKeys}} and {{HdfsClientConfigKeys}} 
together cover all config keys in {{hdfs-default.xml}}, we need to put both of 
them in {{TestHdfsConfigFields#configurationClasses}}.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to